[GitHub] [trafficserver] bryancall commented on a change in pull request #8331: Change the function signature of safe_[get|set]sockopt

[GitBox <gi...@apache.org>]

bryancall commented on a change in pull request #8331:
URL: https://github.com/apache/trafficserver/pull/8331#discussion_r712572296



##########
File path: include/tscore/ink_sock.h
##########
@@ -34,8 +34,8 @@
 
 #include "tscore/ink_apidefs.h"
 
-int safe_setsockopt(int s, int level, int optname, char *optval, int optlevel);
-int safe_getsockopt(int s, int level, int optname, char *optval, int *optlevel);
+int safe_setsockopt(int s, int level, int optname, void *optval, int optlevel);
+int safe_getsockopt(int s, int level, int optname, void *optval, int *optlevel);

Review comment:
       If you are going to mirror the setsockopt API then shouldn't it be const void * and socklen_t for the length?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org