You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/07/10 03:10:03 UTC
[GitHub] [arrow] assignUser opened a new pull request, #36584: MINOR: [C==
assignUser opened a new pull request, #36584:
URL: https://github.com/apache/arrow/pull/36584
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36584: MINOR: [C++] Cleanup FindgRPCAlt
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36584:
URL: https://github.com/apache/arrow/pull/36584#discussion_r1257683765
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -36,7 +36,7 @@ if(GRPCPP_PC_FOUND)
# gRPC's pkg-config file neglects to specify pthreads.
find_package(Threads REQUIRED)
if(ARROW_GRPC_USE_SHARED)
- set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES} Threads::Threads)
+ list(APPEND GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})
Review Comment:
It will create the list if it does not exists but I see how using set is more expressive (also less chars :D).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36584: MINOR: [C++] Cleanup FindgRPCAlt
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36584:
URL: https://github.com/apache/arrow/pull/36584#discussion_r1257681400
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -36,7 +36,7 @@ if(GRPCPP_PC_FOUND)
# gRPC's pkg-config file neglects to specify pthreads.
find_package(Threads REQUIRED)
if(ARROW_GRPC_USE_SHARED)
- set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES} Threads::Threads)
+ list(APPEND GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})
Review Comment:
Could you use `set()` instead of `list(APPEND)` because we don't use any pre-defined `GRPCPP_LINK_LIBRARIES` here?
```suggestion
set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #36584: MINOR: [C++] Cleanup FindgRPCAlt
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #36584:
URL: https://github.com/apache/arrow/pull/36584#discussion_r1257677054
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -36,7 +36,6 @@ if(GRPCPP_PC_FOUND)
# gRPC's pkg-config file neglects to specify pthreads.
find_package(Threads REQUIRED)
if(ARROW_GRPC_USE_SHARED)
- set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES} Threads::Threads)
Review Comment:
Ah I missed the `_PC_` I thought it was just old append syntax, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36584: MINOR: [C++] Cleanup FindgRPCAlt
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36584:
URL: https://github.com/apache/arrow/pull/36584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36584: MINOR: [C++] Cleanup FindgrpcAlt
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36584:
URL: https://github.com/apache/arrow/pull/36584#discussion_r1257675031
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -36,7 +36,6 @@ if(GRPCPP_PC_FOUND)
# gRPC's pkg-config file neglects to specify pthreads.
find_package(Threads REQUIRED)
if(ARROW_GRPC_USE_SHARED)
- set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES} Threads::Threads)
Review Comment:
Could you keep `GRPCPP_PC_LINK_LIBRARIES`?
`set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36584: MINOR: [C++] Cleanup FindgRPCAlt
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36584:
URL: https://github.com/apache/arrow/pull/36584#issuecomment-1646191186
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3d006682dc7c50b4a87c14f57672c853c1e16b1f.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15246628029) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org