You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by dmmata <gi...@git.apache.org> on 2014/02/21 12:38:23 UTC
[GitHub] incubator-storm pull request: STORM-32 - Turn Nimbus JMX port on b...
GitHub user dmmata opened a pull request:
https://github.com/apache/incubator-storm/pull/39
STORM-32 - Turn Nimbus JMX port on by default
Modified defaults.yaml to set nimbus JMX active by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmmata/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit b5c122221a03376f283151d1dafef885588e79f6
Author: dmmata <dm...@gmail.com>
Date: 2014-02-10T11:00:36Z
STORM-32 - Turn Nimbus JMX port on by default
Modified defaults.yaml to set nimbus JMX active by default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-storm pull request: STORM-32 - Turn Nimbus JMX port on b...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/39#issuecomment-49952708
@dmmata would you mind closing this pull request or addressing the concerns that have been raised?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-32 - Turn Nimbus JMX port on b...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/39#issuecomment-47280552
I see the usefulness of this, however I am -0 only because when the security branch changes are accepted, this probably then would be considered a vulnerability that we would revert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-32 - Turn Nimbus JMX port on b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-32 - Turn Nimbus JMX port on b...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/39#issuecomment-47290556
I'm actually -1 for this kind of change. For the reasons @d2r mentioned as well as the fact that I fell Storm should provide sane, and minimal, defaults, and users should only have to override them when they need to.
So I think this comes down to more of a documentation issue. I think it would be better to have instructions on how to enable jmx in the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---