You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (Created) (JIRA)" <ji...@apache.org> on 2011/09/29 16:12:45 UTC
[jira] [Created] (JCR-3087) InternalVersionHistoryImpl might throw
RuntimeException
InternalVersionHistoryImpl might throw RuntimeException
-------------------------------------------------------
Key: JCR-3087
URL: https://issues.apache.org/jira/browse/JCR-3087
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-core
Reporter: Julian Reschke
InternalVersionHistoryImpl.getVersion currently wraps RepositoryExceptions that occur on "reload()" into a RuntimeException. This may cause the RepositoryChecker to abort when attempting to fix a repository, defeating the point of running it.
I see two options:
1) Add "throws RepositoryException" to the signature so no wrapping is needed; this *will* cause similar changes in various interfaces and implementations; but it appears to be straightforward.
2) Modify the RepositoryChecker to catch RuntimeExceptions as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3087) InternalVersionHistoryImpl might throw
RuntimeException
Posted by "Julian Reschke (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved JCR-3087.
---------------------------------
Resolution: Not A Problem
> InternalVersionHistoryImpl might throw RuntimeException
> -------------------------------------------------------
>
> Key: JCR-3087
> URL: https://issues.apache.org/jira/browse/JCR-3087
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> InternalVersionHistoryImpl.getVersion currently wraps RepositoryExceptions that occur on "reload()" into a RuntimeException. This may cause the RepositoryChecker to abort when attempting to fix a repository, defeating the point of running it.
> I see two options:
> 1) Add "throws RepositoryException" to the signature so no wrapping is needed; this *will* cause similar changes in various interfaces and implementations; but it appears to be straightforward.
> 2) Modify the RepositoryChecker to catch RuntimeExceptions as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3087) InternalVersionHistoryImpl might
throw RuntimeException
Posted by "Julian Reschke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120853#comment-13120853 ]
Julian Reschke commented on JCR-3087:
-------------------------------------
It appears there's no problem here as RuntimeException indeed is a subclass of Exception and thus gets catched in RepositoryChecker.checkVersionHistory().
> InternalVersionHistoryImpl might throw RuntimeException
> -------------------------------------------------------
>
> Key: JCR-3087
> URL: https://issues.apache.org/jira/browse/JCR-3087
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> InternalVersionHistoryImpl.getVersion currently wraps RepositoryExceptions that occur on "reload()" into a RuntimeException. This may cause the RepositoryChecker to abort when attempting to fix a repository, defeating the point of running it.
> I see two options:
> 1) Add "throws RepositoryException" to the signature so no wrapping is needed; this *will* cause similar changes in various interfaces and implementations; but it appears to be straightforward.
> 2) Modify the RepositoryChecker to catch RuntimeExceptions as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3087) InternalVersionHistoryImpl might throw
RuntimeException
Posted by "Julian Reschke (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-3087:
-----------------------------------
Assignee: Julian Reschke
> InternalVersionHistoryImpl might throw RuntimeException
> -------------------------------------------------------
>
> Key: JCR-3087
> URL: https://issues.apache.org/jira/browse/JCR-3087
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> InternalVersionHistoryImpl.getVersion currently wraps RepositoryExceptions that occur on "reload()" into a RuntimeException. This may cause the RepositoryChecker to abort when attempting to fix a repository, defeating the point of running it.
> I see two options:
> 1) Add "throws RepositoryException" to the signature so no wrapping is needed; this *will* cause similar changes in various interfaces and implementations; but it appears to be straightforward.
> 2) Modify the RepositoryChecker to catch RuntimeExceptions as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira