You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/21 11:51:39 UTC
[GitHub] [incubator-yunikorn-k8shim] anuraagnalluri opened a new pull request #358: [YUNIKORN-949] Location of the state dump file should be configurable
anuraagnalluri opened a new pull request #358:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/358
### What is this PR for?
Shim changes for enabling the state dump file should be configurable instead of hardcoded.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/YUNIKORN-949
### How should this be tested?
* Manually using non-helm deployment.
### Screenshots (if appropriate)
### Questions:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] anuraagnalluri commented on pull request #358: [YUNIKORN-949] Location of the state dump file should be configurable
Posted by GitBox <gi...@apache.org>.
anuraagnalluri commented on pull request #358:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/358#issuecomment-1022962088
No longer needed since we will make state dump output path a partition level config property instead of env var.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #358: [YUNIKORN-949] Location of the state dump file should be configurable
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #358:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/358#issuecomment-1018446577
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#358](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/358?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff8bbba) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/406c7ee4c3278699bea8220ec650df52e242604f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (406c7ee) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 62.90% 62.90%
=======================================
Files 41 41
Lines 6104 6104
=======================================
Hits 3840 3840
Misses 2112 2112
Partials 152 152
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/358?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/358?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [406c7ee...ff8bbba](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/358?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] anuraagnalluri closed pull request #358: [YUNIKORN-949] Location of the state dump file should be configurable
Posted by GitBox <gi...@apache.org>.
anuraagnalluri closed pull request #358:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org