You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:52:17 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #2280: [NETBEANS-4443] PHP 8.0 Support: throw Expression part

junichi11 opened a new pull request #2280:
URL: https://github.com/apache/netbeans/pull/2280


   https://issues.apache.org/jira/browse/NETBEANS-4443
   
   - https://wiki.php.net/rfc/throw_expression
   - Convert the `ThrowStatement` to the `ThrowExpression`
   - Add unit tests for the parser, the formatter, and the comment generator
   - Fix the `PHP80UnhandledError`
   
   ![nb-php80-throw-expression](https://user-images.githubusercontent.com/738383/88795549-2f4f7180-d1db-11ea-948c-e6187af7fdac.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #2280: [NETBEANS-4443] PHP 8.0 Support: throw Expression part

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2280:
URL: https://github.com/apache/netbeans/pull/2280


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2280: [NETBEANS-4443] PHP 8.0 Support: throw Expression part

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2280:
URL: https://github.com/apache/netbeans/pull/2280#discussion_r465711751



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/verification/UnreachableStatementHint.java
##########
@@ -246,12 +247,23 @@ public void visit(ContinueStatement node) {
         }
 
         @Override
-        public void visit(ThrowStatement node) {
+        public void visit(ExpressionStatement node) {
             if (CancelSupport.getDefault().isCancelled()) {
                 return;
             }
             super.visit(node);
-            processLastStatement(node);
+            // PHP 8.0: throw statement -> throw expression

Review comment:
       Great, thanks!
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #2280: [NETBEANS-4443] PHP 8.0 Support: throw Expression part

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2280:
URL: https://github.com/apache/netbeans/pull/2280#discussion_r465348026



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/verification/UnreachableStatementHint.java
##########
@@ -246,12 +247,23 @@ public void visit(ContinueStatement node) {
         }
 
         @Override
-        public void visit(ThrowStatement node) {
+        public void visit(ExpressionStatement node) {
             if (CancelSupport.getDefault().isCancelled()) {
                 return;
             }
             super.visit(node);
-            processLastStatement(node);
+            // PHP 8.0: throw statement -> throw expression

Review comment:
       Will do it. Thank you!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2280: [NETBEANS-4443] PHP 8.0 Support: throw Expression part

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2280:
URL: https://github.com/apache/netbeans/pull/2280#discussion_r465096513



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/verification/UnreachableStatementHint.java
##########
@@ -246,12 +247,23 @@ public void visit(ContinueStatement node) {
         }
 
         @Override
-        public void visit(ThrowStatement node) {
+        public void visit(ExpressionStatement node) {
             if (CancelSupport.getDefault().isCancelled()) {
                 return;
             }
             super.visit(node);
-            processLastStatement(node);
+            // PHP 8.0: throw statement -> throw expression

Review comment:
       Usually, it is a good idea to add also a number of PR and/or issue.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists