You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/26 05:38:24 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request, #21188: Refactor : refactor the github action workflow
taojintianxia opened a new pull request, #21188:
URL: https://github.com/apache/shardingsphere/pull/21188
for #21184 .
Changes proposed in this pull request:
- format the order of metrix
- rename some workflow and drop the duplicated codecov job
- refactor maven OPS in CI
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
---
<img width="974" alt="image" src="https://user-images.githubusercontent.com/4112856/192200906-b3819717-f299-494d-9657-89f3b7db9a3e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #21188: Refactor : refactor the github action workflow
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #21188:
URL: https://github.com/apache/shardingsphere/pull/21188#discussion_r979701721
##########
.github/workflows/ci.yml:
##########
@@ -77,11 +77,11 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ key: shardingsphere-it-cache-${{ github.sha }}
Review Comment:
you are right, will refactor in next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #21188: Refactor : refactor the github action workflow
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21188:
URL: https://github.com/apache/shardingsphere/pull/21188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #21188: Refactor : refactor the github action workflow
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #21188:
URL: https://github.com/apache/shardingsphere/pull/21188#discussion_r979583188
##########
.github/workflows/ci.yml:
##########
@@ -77,11 +77,11 @@ jobs:
uses: actions/cache@v2
with:
path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ key: shardingsphere-it-cache-${{ github.sha }}
Review Comment:
Maybe `hashFiles('**/pom.xml')` is better than `github.sha`, since `github.sha` is changed frequently, but `hashFiles('**/pom.xml')` might be not changed, so cache could be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org