You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/05/25 13:07:42 UTC
[GitHub] [arrow] lidavidm opened a new issue, #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
lidavidm opened a new issue, #35760:
URL: https://github.com/apache/arrow/issues/35760
### Describe the bug, including details regarding any error messages, version, and platform.
This is supposed to be redundant; the `release` method is supposed to do this itself (as evidenced by the asserts), but this would guard against producers that forget to do so (like https://github.com/apache/arrow-nanoarrow/issues/203) and prevent runtime crashes.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35760:
URL: https://github.com/apache/arrow/issues/35760#issuecomment-1572151744
Perhaps add a debug-mode `assert` that the release callback cleared itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #35760:
URL: https://github.com/apache/arrow/issues/35760#issuecomment-1572154435
There is a debug assert, but outside of Arrow-C++-internal development, I think it's likely people will be using release packages for convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #35760:
URL: https://github.com/apache/arrow/issues/35760#issuecomment-1562931034
I would argue that an implementation that forgets to do this *should* crash...it's a MUST in the spec and the nanoarrow.hpp implementation of the ArrowArrayStream was doing something that violated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
URL: https://github.com/apache/arrow/issues/35760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #35760:
URL: https://github.com/apache/arrow/issues/35760#issuecomment-1562940877
I think a crash isn't very friendly, but at least then an explicit assert (that isn't removed in release builds) might be better so it's clear what happened? It's not great to have to fire up a debugger (especially in Python or R) to see what happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #35760:
URL: https://github.com/apache/arrow/issues/35760#issuecomment-1562953031
That seems like a good middle ground...if Arrow C++ hadn't caught this by crashing I probably wouldn't know about it and some other consumer might have crashed (I can see how if you mostly develop using brew or conda builds that it's a pain, though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #35760: [C++] `ArrowArrayStreamRelease` et al should clear the `ArrowArrayStream`
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #35760:
URL: https://github.com/apache/arrow/issues/35760#issuecomment-1572155889
Hmm, fair enough :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org