You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/11/23 07:04:59 UTC

Review Request 64046: Incorrect pie chart distribution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64046/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22506
    https://issues.apache.org/jira/browse/AMBARI-22506


Repository: ambari


Description
-------

Phoenix JDBC does number formatting if its a decimal, as describe in https://phoenix.apache.org/tuning.html "phoenix.query.numberFormat" with "#,##0.###", which causes a problem with displaying of graph.


Diffs
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py 5efc277caf 


Diff: https://reviews.apache.org/r/64046/diff/1/


Testing
-------

Manually


Thanks,

Prabhjyot Singh


Re: Review Request 64046: Incorrect pie chart distribution

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64046/#review191785
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On Nov. 23, 2017, 7:04 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64046/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 7:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22506
>     https://issues.apache.org/jira/browse/AMBARI-22506
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Phoenix JDBC does number formatting if its a decimal, as describe in https://phoenix.apache.org/tuning.html "phoenix.query.numberFormat" with "#,##0.###", which causes a problem with displaying of graph.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py 5efc277caf 
> 
> 
> Diff: https://reviews.apache.org/r/64046/diff/1/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 64046: Incorrect pie chart distribution

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64046/#review191787
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Nov. 23, 2017, 7:04 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64046/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 7:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22506
>     https://issues.apache.org/jira/browse/AMBARI-22506
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Phoenix JDBC does number formatting if its a decimal, as describe in https://phoenix.apache.org/tuning.html "phoenix.query.numberFormat" with "#,##0.###", which causes a problem with displaying of graph.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py 5efc277caf 
> 
> 
> Diff: https://reviews.apache.org/r/64046/diff/1/
> 
> 
> Testing
> -------
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 64046: Incorrect pie chart distribution

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64046/
-----------------------------------------------------------

(Updated Nov. 24, 2017, 10:32 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22506
    https://issues.apache.org/jira/browse/AMBARI-22506


Repository: ambari


Description
-------

Phoenix JDBC does number formatting if its a decimal, as describe in https://phoenix.apache.org/tuning.html "phoenix.query.numberFormat" with "#,##0.###", which causes a problem with displaying of graph.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py 5efc277caf 


Diff: https://reviews.apache.org/r/64046/diff/2/

Changes: https://reviews.apache.org/r/64046/diff/1-2/


Testing
-------

Manually


Thanks,

Prabhjyot Singh