[GitHub] [arrow] candiduslynx commented on a diff in pull request #36163: GH-36095: [Go] Add doc for `pqarrow.FileWriter.WriteBuffered`

["candiduslynx (via GitHub)" <gi...@apache.org>]

candiduslynx commented on code in PR #36163:
URL: https://github.com/apache/arrow/pull/36163#discussion_r1234761572


##########
go/parquet/pqarrow/file_writer.go:
##########
@@ -134,6 +134,13 @@ func (fw *FileWriter) RowGroupTotalBytesWritten() int64 {
 	return 0
 }
 
+// WriteBuffered allows to write records and decide where to break your row group
+// based on the TotalBytesWritten rather than on the max row group len.

Review Comment:
   Done in 9c4ca94137a143986e69feb07a0ab94baee7e334



##########
go/parquet/pqarrow/file_writer.go:
##########
@@ -181,7 +188,10 @@ func (fw *FileWriter) WriteBuffered(rec arrow.Record) error {
 }
 
 // Write an arrow Record Batch to the file, respecting the MaxRowGroupLength in the writer
-// properties to determine whether or not a new row group is created while writing.
+// properties to determine whether a new row group is created or not while writing.

Review Comment:
   Done in 9c4ca94137a143986e69feb07a0ab94baee7e334



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org