[GitHub] [spark] Andrew-Crosby opened a new pull request #24880: [SPARK-28062][ML] Avoid unnecessary copy of coefficients vector in HuberAggregator

[GitBox <gi...@apache.org>]

Andrew-Crosby opened a new pull request #24880: [SPARK-28062][ML] Avoid unnecessary copy of coefficients vector in HuberAggregator
URL: https://github.com/apache/spark/pull/24880
 
 
   ## What changes were proposed in this pull request?
   
   Modifies the HuberAggregator class so that a copy of the coefficients vector isn't created 
   every time that an instance is added. Follows the approach of LeastSquaresAggregator 
   and uses transient lazy class variable to store the reused quantities.
   
   I'm not particularly familiar with the interaction between serialization and broadcast 
   variables, but I wonder if the sigma, and intercept class variables should be tagged as
   transient and lazy as well?
   
   ## How was this patch tested?
   
   Existing unit tests.
   See https://issues.apache.org/jira/browse/SPARK-28062 for results from running a benchmark script.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org