[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965#discussion_r931340354


##########
datafusion/core/src/physical_plan/file_format/avro.rs:
##########
@@ -24,17 +24,23 @@ use crate::physical_plan::{
 use arrow::datatypes::SchemaRef;
 
 use crate::execution::context::TaskContext;
+#[cfg(feature = "avro")]
+use crate::physical_plan::metrics::BaselineMetrics;
+use crate::physical_plan::metrics::ExecutionPlanMetricsSet;
 use std::any::Any;
 use std::sync::Arc;
 
 use super::FileScanConfig;
 
 /// Execution plan for scanning Avro data source
 #[derive(Debug, Clone)]
+#[allow(dead_code)]

Review Comment:
   Not sure why this is needed



##########
datafusion/core/src/physical_plan/file_format/avro.rs:
##########
@@ -24,17 +24,23 @@ use crate::physical_plan::{
 use arrow::datatypes::SchemaRef;
 
 use crate::execution::context::TaskContext;
+#[cfg(feature = "avro")]

Review Comment:
   Isn't this whole file `#[cfg(feature = "avro")]` ?
   
   In other words, would this work?
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org