[GitHub] [solr] HoustonPutman commented on a change in pull request #409: SOLR-15786

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #409:
URL: https://github.com/apache/solr/pull/409#discussion_r753533434



##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -2845,8 +2845,42 @@ protected void runExample(CommandLine cli, String exampleName) throws Exception
           echo("exampledocs directory not found, skipping indexing step for the techproducts example");
         }
       }
+      else if ("films".equals(exampleName) && !alreadyExists) {
+        echo("Adding name and initial_release_data fields to films schema \"_default\"");
 
-      echo("\nSolr "+exampleName+" example launched successfully. Direct your Web browser to "+solrUrl+" to visit the Solr Admin UI");
+        HttpSolrClient solrClient = new HttpSolrClient.Builder(solrUrl).build();
+        try {
+          SolrCLI.postJsonToSolr(solrClient, "/" + collectionName + "/schema", "{\n" +

Review comment:
       > Example of using the _default configset and adding fields dynamically.
   
   That makes me think that films is just using the dynamic fields available in _default, but here you are adding a few fields. Maybe we convert it to only use dynamic fields, or change the description to be a little clearer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org