You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fattalgazi <gi...@git.apache.org> on 2016/01/18 12:04:43 UTC
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
GitHub user fattalgazi opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/154
Chrome , Uncaught TypeError: localStream.stop is not a function
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fattalgazi/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit e092e4fbb709925c6ac961b57a7e5f6f59550042
Author: fattalgazi <fa...@gmail.com>
Date: 2016-01-18T10:52:50Z
Update CameraProxy.js
localMediaStream.stop() fix
commit 5e81cdcec4b78dcc1c78537f9310cd27683847ad
Author: fattalgazi <fa...@gmail.com>
Date: 2016-01-18T10:56:19Z
Update CameraProxy.js
commit c17a297ad5d5b5b80b9f727aa0770ac740d4c67c
Author: fattalgazi <fa...@gmail.com>
Date: 2016-01-18T11:01:37Z
Update CameraProxy.js
commit 0e03410f6ef8c8eff87ceb652764e6a362fc348b
Author: fattalgazi <fa...@gmail.com>
Date: 2016-01-18T11:03:26Z
Update CameraProxy.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Posted by davetayls <gi...@git.apache.org>.
Github user davetayls commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#discussion_r50270493
--- Diff: src/browser/CameraProxy.js ---
@@ -66,7 +66,15 @@ function capture(success, errorCallback) {
imageData = imageData.replace('data:image/png;base64,', '');
// stop video stream, remove video and button
- localMediaStream.stop();
+ try{
+ localMediaStream.stop();
+ }catch(e){}
+
+ try{
+ localMediaStream.getVideoTracks()[0].stop();
--- End diff --
you could also get an audio track so this might be better as:
```javascript
localMediaStream.getTracks().forEach(function(mediaStream) {
mediaStream.stop();
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Posted by davetayls <gi...@git.apache.org>.
Github user davetayls commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178571365
Thanks Tim, looks good. Are you able to close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Posted by fattalgazi <gi...@git.apache.org>.
Github user fattalgazi closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Posted by fattalgazi <gi...@git.apache.org>.
Github user fattalgazi commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-180725988
thanks, I'm closing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178404256
Ah sorry @fattalgazi - I just fixed this and missed that you already had a PR open. Fixed now in #161.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...
Posted by davetayls <gi...@git.apache.org>.
Github user davetayls commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-173243484
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org