[GitHub] [kafka] skaundinya15 commented on a change in pull request #9142: MINOR: Fix delete_topic for system tests

[GitBox <gi...@apache.org>]

skaundinya15 commented on a change in pull request #9142:
URL: https://github.com/apache/kafka/pull/9142#discussion_r467274037



##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None, use_zk_to_create_topic=True):
         self.logger.info("Running topic creation command...\n%s" % cmd)
         node.account.ssh(cmd)
 
-    def delete_topic(self, topic, node=None):
+    def delete_topic(self, topic, node=None, use_zk_to_delete_topic=False):

Review comment:
       Yeah that's a good point, but in this scenario I was thinking to remain consistent with the original implementation. Also I'm not sure how far we want to backport this, but if we backport it past the version where `--bootstrap-server` is not available, then I think we would have to rewrite this function to account for that. Also since we are on our way to deprecate and remove ZK, this would be a good way to start pushing us towards doing that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org