Re: [PR] [DRAFT]MINOR: Require --dry-run or --execute for reset-offsets in streams-groups tool [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #20933:
URL: https://github.com/apache/kafka/pull/20933#discussion_r2545711093


##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommandOptions.java:
##########
@@ -269,12 +270,8 @@ private void checkOffsetResetArgs() {
         if (options.has(dryRunOpt) && options.has(executeOpt))
             CommandLineUtils.printUsageAndExit(parser, "Option " + resetOffsetsOpt + " only accepts one of " + executeOpt + " and " + dryRunOpt);
 
-        if (!options.has(dryRunOpt) && !options.has(executeOpt)) {

Review Comment:
   ping @bbejeck @lucasbru 
   
   This changes was inspired by the discussion in https://github.com/apache/kafka/pull/20867#discussion_r2522349095, and it ensures the implementation aligns with KIP-1071



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org