You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Joe Bohn <jo...@earthlink.net> on 2009/01/05 21:08:50 UTC
Re: svn commit: r731662 - in /geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared:
EMPTY classes/EMPTY lib/EMPTY
Lin,
I'm confused as to why these are now necessary. It used to be that they
were created in the plugin because they were already included in the
src/main/resources. Even if it is now necessary to add the EMPTY file
in the /shared/lib and /shared/classes subdirectories it should not be
required in the /shared.
Thanks,
Joe
linsun@apache.org wrote:
> Author: linsun
> Date: Mon Jan 5 11:47:54 2009
> New Revision: 731662
>
> URL: http://svn.apache.org/viewvc?rev=731662&view=rev
> Log:
> GERONIMO-4479 add empty files to get the empty shared folder copied
>
> Added:
> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/EMPTY
> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/classes/EMPTY
> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/lib/EMPTY
>
> Added: geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/EMPTY
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/EMPTY?rev=731662&view=auto
> ==============================================================================
> (empty)
>
> Added: geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/classes/EMPTY
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/classes/EMPTY?rev=731662&view=auto
> ==============================================================================
> (empty)
>
> Added: geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/lib/EMPTY
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/lib/EMPTY?rev=731662&view=auto
> ==============================================================================
> (empty)
>
>
>
Re: svn commit: r731662 - in /geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared: EMPTY classes/EMPTY lib/EMPTY
Posted by Lin Sun <li...@gmail.com>.
Hi Joe, thanks for the review.
I added these back in because in GERONIMO-4479, it reports the following error -
2008-12-30 16:24:38,953 ERROR [PluginInstallerGBean] Installed 'org.apache.geron
imo.configs/sharedlib/2.2-SNAPSHOT/car' configuration into repository but cannot
locate file to copy shared
The error is not important at all and should not impact any function
after I found out the cause, but it looks a big prob to our end user.
The defect is marked as blocker proved that. :-)
Basically, sharedlib plugin's metadata instructs the plugininstaller
to copy the shared directory, but the plugininstaller cannot find the
shared directory because it got lost somewhere when we install it.
And the only reason it got lost is because it is an empty folder which
we don't handle well.
Jarek reminded me offline that he has a workaround to copy the empty
folders into the sharedlib plugin and I am trying to see if we can
preserve the empty folder during install of the plugin (without adding
the EMPTY file).
Thanks again
Lin
On Mon, Jan 5, 2009 at 3:08 PM, Joe Bohn <jo...@earthlink.net> wrote:
> Lin,
>
> I'm confused as to why these are now necessary. It used to be that they
> were created in the plugin because they were already included in the
> src/main/resources. Even if it is now necessary to add the EMPTY file in
> the /shared/lib and /shared/classes subdirectories it should not be required
> in the /shared.
>
> Thanks,
> Joe
>
> linsun@apache.org wrote:
>>
>> Author: linsun
>> Date: Mon Jan 5 11:47:54 2009
>> New Revision: 731662
>>
>> URL: http://svn.apache.org/viewvc?rev=731662&view=rev
>> Log:
>> GERONIMO-4479 add empty files to get the empty shared folder copied
>>
>> Added:
>> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/EMPTY
>>
>> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/classes/EMPTY
>>
>> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/lib/EMPTY
>>
>> Added:
>> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/EMPTY
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/EMPTY?rev=731662&view=auto
>>
>> ==============================================================================
>> (empty)
>>
>> Added:
>> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/classes/EMPTY
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/classes/EMPTY?rev=731662&view=auto
>>
>> ==============================================================================
>> (empty)
>>
>> Added:
>> geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/lib/EMPTY
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/sharedlib/src/main/resources/shared/lib/EMPTY?rev=731662&view=auto
>>
>> ==============================================================================
>> (empty)
>>
>>
>>
>
>