You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "sgrebnov (via GitHub)" <gi...@apache.org> on 2026/04/01 09:53:49 UTC

[PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

sgrebnov opened a new pull request, #21295:
URL: https://github.com/apache/datafusion/pull/21295

   ## Which issue does this PR close?
   
   ⚠️ Draft while manually verifying updated format against PG, MySQL, DuckDB, BigQuery 
   
   - Closes #21294.
   
   ## Rationale for this change
   
   The default `timestamp_with_tz_to_string` uses `DateTime<Tz>.to_string()`, which produces literals like `2025-09-15 11:00:00 +00:00` that are not supported by multiple dialects (e.g. DuckDB, BigQuery). Switching to `to_rfc3339()` produces valid ISO 8601 / RFC 3339 strings (e.g. `2025-09-15T11:00:00+00:00`) that are broadly compatible.
   
   ## What changes are included in this PR?
   
   - Changed the default `Dialect::timestamp_with_tz_to_string` implementation from `dt.to_string()` to `dt.to_rfc3339()`
   - Removed now-redundant `timestamp_with_tz_to_string` overrides from `DuckDBDialect` and `BigQueryDialect` (they produced equivalent RFC 3339-compatible output via custom format strings)
   - Updated test expectations to match the new default format
   
   ## Are these changes tested?
   
   Yes, existing tests in `unparser::expr::tests` have been updated to reflect the new format.
   
   ## Are there any user-facing changes?
   
   Yes — timestamp-with-timezone literals are now formatted as RFC 3339 (`2025-09-15T11:00:00+00:00`) instead of the previous `Display` format (`2025-09-15 11:00:00 +00:00`). Dialects that need a different format can still override `timestamp_with_tz_to_string`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183438855

   🤔  but a bunch of the tests seem to have failed after merge to main https://github.com/apache/datafusion/commit/5b0938de9131eb38e4af2d4c9442e1ab8929add2
   
   
   <img width="1599" height="959" alt="Screenshot 2026-04-03 at 9 16 15 AM" src="https://github.com/user-attachments/assets/9c5fab1f-92ed-4267-89c3-5963d4feede1" />
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #21295: fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting
URL: https://github.com/apache/datafusion/pull/21295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183528068

   > > I think that's correct - Rust tests are not required-to-merge (and hence not ran by the merge queue yet) - only dev.yaml does. The plan is to wait for a few days and do the same operation for the rest of the CI
   > > For now, Rust checks should work as before ("push" not "merge group" checks)
   > 
   > This could be a bit counterintuitive, but for now we can maybe monitor the CI and see how it goes
   
   Yeah, what i find counter intuitive is that the main commit list now looks like this commit failed CI:
   
   https://github.com/apache/datafusion
   
   <img width="1680" height="880" alt="Screenshot 2026-04-03 at 9 38 50 AM" src="https://github.com/user-attachments/assets/b2d1ce18-a725-4fef-b558-1368a54baa88" />
   
   Looks like main is broken since we enabled the queue:
   https://github.com/apache/datafusion/commits/main/
   
   
   <img width="1640" height="839" alt="Screenshot 2026-04-03 at 9 39 47 AM" src="https://github.com/user-attachments/assets/bc3b1fae-3536-4e9c-ae0d-03e1f90a52cb" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #21295:
URL: https://github.com/apache/datafusion/pull/21295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183480486

   ![image](https://github.com/user-attachments/assets/1f3ca664-c6cd-4a11-919e-c095604b961d)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183554615

   oh, that should be an easy fix! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "AndreaBozzo (via GitHub)" <gi...@apache.org>.
AndreaBozzo commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4169185311

   Seems solid, waiting for someone else to take another look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "AndreaBozzo (via GitHub)" <gi...@apache.org>.
AndreaBozzo commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183492018

   > I think that's correct - Rust tests are not required-to-merge (and hence not ran by the merge queue yet) - only dev.yaml does. The plan is to wait for a few days and do the same operation for the rest of the CI
   > 
   > For now, Rust checks should work as before ("push" not "merge group" checks)
   
   This could be a bit counterintuitive, but for now we can maybe monitor the CI and see how it goes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183305672

   🚀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183410057

   This was the first PR that got merged using the new PR merge queue from @blaginin 
   - https://github.com/apache/datafusion/pull/21239
   
   It seems to have gone really well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183372230

   Close/reopen PR to rerun checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183473380

   I think that's correct - Rust tests are not required-to-merge (and hence not ran by the merge queue yet) - only dev.yaml does. The plan is to wait for a few days and do the same operation for the rest of the CI
   
   For now, Rust checks should work as before ("push" not "merge group" checks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] fix(unparser): use to_rfc3339 for default TIMESTAMPTZ formatting [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21295:
URL: https://github.com/apache/datafusion/pull/21295#issuecomment-4183562286

   https://github.com/apache/datafusion/pull/21343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org