You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/08 09:45:35 UTC

[GitHub] [maven] gnodet edited a comment on pull request #632: [MNG-7351] clarify differences between MojoFailureException and MojoExecutionException in javadoc

gnodet edited a comment on pull request #632:
URL: https://github.com/apache/maven/pull/632#issuecomment-988654452


   > Dug a bit deeper and found
   > 
   > https://github.com/apache/maven/blob/ed370a6382ee4e431d36ae38454174b94d4f33aa/maven-core/src/main/java/org/apache/maven/DefaultMaven.java#L235-L255
   > 
   > for the different handling.
   
   Now, the exceptions are handled in [`BuilderCommon`](https://github.com/apache/maven/blob/3982c195e91e3ea0f73ce9e61c6ddc57137726e9/maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java) and no case is done whether the exception is a `MojoFailureException` or `MojoExecutionException` which is coherent with your experiments.  If we confirm this, I'd change the javadoc and eventually deprecate one of the exceptions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org