You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2006/06/14 11:59:30 UTC

[jira] Updated: (JAMES-530) Add more spool manage commands to RemoteManager

     [ http://issues.apache.org/jira/browse/JAMES-530?page=all ]

Norman Maurer updated JAMES-530:
--------------------------------

    Attachment: SpoolCmds.patch

Here is my current work. Plz have a look. I Consider to match only agains Headers not the complete message.

Anyway all critic etc is welcome. 

> Add more spool manage commands to RemoteManager
> -----------------------------------------------
>
>          Key: JAMES-530
>          URL: http://issues.apache.org/jira/browse/JAMES-530
>      Project: James
>         Type: New Feature

>   Components: Remote Manager
>     Reporter: Norman Maurer
>     Assignee: Norman Maurer
>  Attachments: SpoolCmds.patch
>
> We should add more commands to handle the spool from RemoteManger. For example something like : 
> -remove all mail which has subject = "test"
> -remove all mail which has sender = xyz;
> .....
> Maybe also regex etc. 
> Thats very usefull if your queue was grow up with spam bounces which can not delivered etc.. 
> We had such a case in the lastyear where our queue was about 1million emails!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Updated: (JAMES-530) Add more spool manage commands to RemoteManager

Posted by Bernd Fondermann <be...@googlemail.com>.
Hi Norman,

Making James more manageble at runtime is really appreciated. I am
planing to extend the JMX counterparts to RemoteManager soon.

That's also why I propose to move all the 'business logic' out of the
RemoteManHandler into some spooling utility class. This would allow
for other management interfaces (e.g. JMX) to reuse the logic.

Maybe I am overly critical, but I really dislike the copy-pastes of
larger chunks of code. Makes it so much harder to read the patch and
maintain the code.

More general note concerning the help syntax: I'm used to reading
arguments enclosed in [ ] as being optional. Maybe we should change
them into < > and apply the [ ] where arguments are optional?

  Bernd

On 6/14/06, Norman Maurer (JIRA) <se...@james.apache.org> wrote:
>      [ http://issues.apache.org/jira/browse/JAMES-530?page=all ]
>
> Norman Maurer updated JAMES-530:
> --------------------------------
>
>     Attachment: SpoolCmds.patch
>
> Here is my current work. Plz have a look. I Consider to match only agains Headers not the complete message.
>
> Anyway all critic etc is welcome.
>
> > Add more spool manage commands to RemoteManager
> > -----------------------------------------------
> >
> >          Key: JAMES-530
> >          URL: http://issues.apache.org/jira/browse/JAMES-530
> >      Project: James
> >         Type: New Feature
>
> >   Components: Remote Manager
> >     Reporter: Norman Maurer
> >     Assignee: Norman Maurer
> >  Attachments: SpoolCmds.patch
> >
> > We should add more commands to handle the spool from RemoteManger. For example something like :
> > -remove all mail which has subject = "test"
> > -remove all mail which has sender = xyz;
> > .....
> > Maybe also regex etc.
> > Thats very usefull if your queue was grow up with spam bounces which can not delivered etc..
> > We had such a case in the lastyear where our queue was about 1million emails!
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Updated: (JAMES-530) Add more spool manage commands to RemoteManager

Posted by Bernd Fondermann <be...@googlemail.com>.
On 6/16/06, Norman Maurer <nm...@byteaction.de> wrote:
> Am Freitag, den 16.06.2006, 15:12 +0200 schrieb Bernd Fondermann:
> > Maybe I am overly critical, but I really dislike the copy-pastes of
> > larger chunks of code. Makes it so much harder to read the patch and
> > maintain the code.
>
> I knew before that you write this ;-)

:-) ok, I'll try something new next time ;-)

> > More general note concerning the help syntax: I'm used to reading
> > arguments enclosed in [ ] as being optional. Maybe we should change
> > them into < > and apply the [ ] where arguments are optional?
> >
> >   Bernd
>
> This was why i not commit it and only post to jira. I will not commit it
> until i make it a bit cleaner.. Just want to knew what you other guys
> think about it and the way it work ;-)

ok, cool.
reading a cleaner patch would not have taken me 2 days... just kidding ;-)

  Bernd

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Updated: (JAMES-530) Add more spool manage commands to RemoteManager

Posted by Norman Maurer <nm...@byteaction.de>.
Am Freitag, den 16.06.2006, 15:12 +0200 schrieb Bernd Fondermann:
> Hi Norman,
> 
> Making James more manageble at runtime is really appreciated. I am
> planing to extend the JMX counterparts to RemoteManager soon.
> 
> That's also why I propose to move all the 'business logic' out of the
> RemoteManHandler into some spooling utility class. This would allow
> for other management interfaces (e.g. JMX) to reuse the logic.
> 
> Maybe I am overly critical, but I really dislike the copy-pastes of
> larger chunks of code. Makes it so much harder to read the patch and
> maintain the code.

I knew before that you write this ;-)

> More general note concerning the help syntax: I'm used to reading
> arguments enclosed in [ ] as being optional. Maybe we should change
> them into < > and apply the [ ] where arguments are optional?
> 
>   Bernd

This was why i not commit it and only post to jira. I will not commit it
until i make it a bit cleaner.. Just want to knew what you other guys
think about it and the way it work ;-)

bye
Norman