[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9904: Refactor jdbc storage implementations to reuse logics

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #9904:
URL: https://github.com/apache/skywalking/pull/9904#discussion_r1014957314


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ModelInstaller.java:
##########
@@ -58,6 +57,9 @@ public void whenCreating(Model model) throws StorageException {
         }
     }
 
+    public void start() {

Review Comment:
   > What does `ModelInstaller#start` mean?
   
   This is to provide a hook for child-implementations of model installer to do initializations, for now, we do column overrides (e.g. `overrideColumnName("value", "value_");`) in this method.
   
   Previously we do `overrideColumnName("value", "value_");` in the constructor of model installer, this is not an appropriate phase because `overrideColumnName("value", "value_");` requires services that must be already registered to module manager and it might raise `Still in preparing stage` exception if the construction of model installer is too early.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org