You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/05 03:27:25 UTC
[GitHub] [cordova-android] breautek opened a new pull request #1018: fix: gradle ignore properties
breautek opened a new pull request #1018:
URL: https://github.com/apache/cordova-android/pull/1018
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
A regression was made during the refactor of `shelljs` to `execa`. The current working directory was the cordova project root, which caused the gradle properties file in the android project folder to be ignored.
fixes #1011
### Description
<!-- Describe your changes in detail -->
I've specified the cwd in the execa settings in every place that looked appropriate.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran `npm test`
Manually tested my fork.
Easiest way to test is by running `cordova build android`, wait until gradle starts... then run `ps -aux | grep 'Xmx'`
The expected output of the java processes should be something like `/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx2048m`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1018: fix: gradle ignore properties
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1018:
URL: https://github.com/apache/cordova-android/pull/1018#issuecomment-653837572
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=h1) Report
> Merging [#1018](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ba5781c3bf9890dbb5f2a897c33cf274b87b1a81&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
- Coverage 68.33% 68.28% -0.06%
==========================================
Files 20 20
Lines 1854 1854
==========================================
- Hits 1267 1266 -1
- Misses 587 588 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1018/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1018/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.96% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=footer). Last update [ba5781c...cf9525d](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1018: fix: gradle ignore properties
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1018:
URL: https://github.com/apache/cordova-android/pull/1018#issuecomment-653837572
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=h1) Report
> Merging [#1018](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ba5781c3bf9890dbb5f2a897c33cf274b87b1a81&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
- Coverage 68.33% 68.28% -0.06%
==========================================
Files 20 20
Lines 1854 1854
==========================================
- Hits 1267 1266 -1
- Misses 587 588 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1018/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1018/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.96% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=footer). Last update [ba5781c...cf9525d](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1018: fix: gradle ignore properties
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1018:
URL: https://github.com/apache/cordova-android/pull/1018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1018: fix: gradle ignore properties
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1018:
URL: https://github.com/apache/cordova-android/pull/1018#issuecomment-653837572
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=h1) Report
> Merging [#1018](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ba5781c3bf9890dbb5f2a897c33cf274b87b1a81&el=desc) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1018 +/- ##
=======================================
Coverage 68.33% 68.33%
=======================================
Files 20 20
Lines 1854 1854
=======================================
Hits 1267 1267
Misses 587 587
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1018/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `73.21% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=footer). Last update [ba5781c...cf9525d](https://codecov.io/gh/apache/cordova-android/pull/1018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org