You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "leujean02 (via GitHub)" <gi...@apache.org> on 2025/04/08 20:49:59 UTC
[PR] [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos [pinot]
leujean02 opened a new pull request, #15500:
URL: https://github.com/apache/pinot/pull/15500
As per the discussion in [#15437](https://github.com/apache/pinot/pull/15437), I have added `com.google.api.grpc:proto-google-common-protos` to the root POM before the declaration of `com.google.cloud:libraries-bom`.
I made this change because some Google Cloud libraries override the version defined in `io.grpc` bom. Since`com.google.api.grpc:proto-google-common-protos` is a transitive dependency that can be overridden, explicitly pinning its version before importing google cloud libraries allows it to control its version.
Referenced comments:
https://github.com/apache/pinot/pull/15437#discussion_r2027407183
https://github.com/apache/pinot/pull/15437#discussion_r2029552651
cc @siddharthteotia @gviedma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15500:
URL: https://github.com/apache/pinot/pull/15500#issuecomment-2787717677
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15500?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 55.85%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1801564`)](https://app.codecov.io/gh/apache/pinot/commit/1801564f3f834da16a4cc341afdd34c74f576980?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2018 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (59551e4) and HEAD (1801564). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (59551e4) | HEAD (1801564) |
>|------|------|------|
>|integration|7|0|
>|integration2|3|0|
>|temurin|12|2|
>|java-21|7|2|
>|skip-bytebuffers-true|3|1|
>|skip-bytebuffers-false|7|1|
>|unittests|5|2|
>|java-11|5|0|
>|unittests2|3|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #15500 +/- ##
============================================
- Coverage 61.75% 55.85% -5.90%
- Complexity 207 681 +474
============================================
Files 2436 2223 -213
Lines 133233 120065 -13168
Branches 20636 19185 -1451
============================================
- Hits 82274 67065 -15209
- Misses 44911 47472 +2561
+ Partials 6048 5528 -520
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.85% <ø> (-5.77%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.83% <ø> (-5.92%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.82% <ø> (+28.09%)` | :arrow_up: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.85% <ø> (-5.90%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.85% <ø> (-5.90%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.85% <ø> (+8.96%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/15500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/15500?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos [pinot]
Posted by "leujean02 (via GitHub)" <gi...@apache.org>.
leujean02 closed pull request #15500: [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos
URL: https://github.com/apache/pinot/pull/15500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Issue 12676 - Part 2.1] Adding com.google.api.grpc:proto-google-common-protos [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #15500:
URL: https://github.com/apache/pinot/pull/15500#discussion_r2036265349
##########
pom.xml:
##########
@@ -294,6 +294,7 @@
<ipaddress.version>5.5.1</ipaddress.version>
<openhft.posix.version>2.27ea1</openhft.posix.version>
<openhft.chronicle-core.version>2.27ea2</openhft.chronicle-core.version>
+ <proto-google-common-protos.version>2.54.1</proto-google-common-protos.version>
Review Comment:
Put it in the `Google Libraries` section for easier management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org