You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2013/03/14 21:15:35 UTC
svn commit: r1456645 -
/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
Author: simonetripodi
Date: Thu Mar 14 20:15:35 2013
New Revision: 1456645
URL: http://svn.apache.org/r1456645
Log:
checkstyle: Variable 'encodingTable' must be private and have accessor methods
Modified:
commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java?rev=1456645&r1=1456644&r2=1456645&view=diff
==============================================================================
--- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java (original)
+++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java Thu Mar 14 20:15:35 2013
@@ -24,7 +24,7 @@ import java.io.OutputStream;
*/
final class Base64Decoder {
- protected final byte[] encodingTable = {
+ protected final byte[] ENCODING_TABLE = {
(byte)'A', (byte)'B', (byte)'C', (byte)'D', (byte)'E', (byte)'F', (byte)'G',
(byte)'H', (byte)'I', (byte)'J', (byte)'K', (byte)'L', (byte)'M', (byte)'N',
(byte)'O', (byte)'P', (byte)'Q', (byte)'R', (byte)'S', (byte)'T', (byte)'U',
@@ -47,8 +47,8 @@ final class Base64Decoder {
protected final byte[] decodingTable = new byte[256];
protected void initialiseDecodingTable() {
- for (int i = 0; i < encodingTable.length; i++) {
- decodingTable[encodingTable[i]] = (byte)i;
+ for (int i = 0; i < ENCODING_TABLE.length; i++) {
+ decodingTable[ENCODING_TABLE[i]] = (byte)i;
}
}
Re: svn commit: r1456645 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
Posted by Simone Tripodi <si...@apache.org>.
>> checkstyle: Variable 'encodingTable' must be private and have accessor methods
>
> Log comment does not agree with the change below.
OUCH!
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1456645 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
Posted by sebb <se...@gmail.com>.
On 14 March 2013 20:15, <si...@apache.org> wrote:
> Author: simonetripodi
> Date: Thu Mar 14 20:15:35 2013
> New Revision: 1456645
>
> URL: http://svn.apache.org/r1456645
> Log:
> checkstyle: Variable 'encodingTable' must be private and have accessor methods
Log comment does not agree with the change below.
> Modified:
> commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
>
> Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
> URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java?rev=1456645&r1=1456644&r2=1456645&view=diff
> ==============================================================================
> --- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java (original)
> +++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java Thu Mar 14 20:15:35 2013
> @@ -24,7 +24,7 @@ import java.io.OutputStream;
> */
> final class Base64Decoder {
>
> - protected final byte[] encodingTable = {
> + protected final byte[] ENCODING_TABLE = {
> (byte)'A', (byte)'B', (byte)'C', (byte)'D', (byte)'E', (byte)'F', (byte)'G',
> (byte)'H', (byte)'I', (byte)'J', (byte)'K', (byte)'L', (byte)'M', (byte)'N',
> (byte)'O', (byte)'P', (byte)'Q', (byte)'R', (byte)'S', (byte)'T', (byte)'U',
> @@ -47,8 +47,8 @@ final class Base64Decoder {
> protected final byte[] decodingTable = new byte[256];
>
> protected void initialiseDecodingTable() {
> - for (int i = 0; i < encodingTable.length; i++) {
> - decodingTable[encodingTable[i]] = (byte)i;
> + for (int i = 0; i < ENCODING_TABLE.length; i++) {
> + decodingTable[ENCODING_TABLE[i]] = (byte)i;
> }
> }
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org