You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/12/09 03:19:59 UTC
[jira] [Commented] (HBASE-9774) Provide a way for coprocessors to
register and report custom metrics
[ https://issues.apache.org/jira/browse/HBASE-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734145#comment-15734145 ]
Hadoop QA commented on HBASE-9774:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s {color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 13 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s {color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 44s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 5s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 20s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 3s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 21s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 12s {color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 47s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: . hbase-assembly {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 32s {color} | {color:red} hbase-examples generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 8s {color} | {color:red} hbase-metrics-api generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 59s {color} | {color:red} root generated 4 new + 19 unchanged - 0 fixed = 23 total (was 19) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 39s {color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 55s {color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s {color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s {color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 30s {color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 11s {color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 17s {color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s {color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 12s {color} | {color:red} hbase-metrics in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 76m 4s {color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 2m 17s {color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 171m 10s {color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-examples |
| | Read of unwritten field disableTableCounter in org.apache.hadoop.hbase.coprocessor.example.ExampleMasterObserverWithMetrics.preDisableTable(ObserverContext, TableName) At ExampleMasterObserverWithMetrics.java:in org.apache.hadoop.hbase.coprocessor.example.ExampleMasterObserverWithMetrics.preDisableTable(ObserverContext, TableName) At ExampleMasterObserverWithMetrics.java:[line 94] |
| | Unwritten field:ExampleMasterObserverWithMetrics.java:[line 94] |
| Failed junit tests | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL |
| | hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | hadoop.hbase.replication.TestReplicationDisableInactivePeer |
| | hadoop.hbase.replication.TestReplicationSmallTests |
| | hadoop.hbase.replication.TestReplicationSyncUpTool |
| | hadoop.hbase.replication.TestReplicationEndpoint |
| | hadoop.hbase.replication.TestNamespaceReplication |
| | hadoop.hbase.replication.TestReplicationKillMasterRS |
| | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers |
| | hadoop.hbase.replication.TestReplicationKillSlaveRS |
| | hadoop.hbase.metrics.impl.TestTimerImpl |
| | hadoop.hbase.metrics.impl.TestTimerImpl |
| | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL |
| | hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | hadoop.hbase.replication.TestReplicationDisableInactivePeer |
| | hadoop.hbase.replication.TestReplicationSmallTests |
| | hadoop.hbase.replication.TestReplicationSyncUpTool |
| | hadoop.hbase.replication.TestReplicationEndpoint |
| | hadoop.hbase.replication.TestNamespaceReplication |
| | hadoop.hbase.replication.TestReplicationKillMasterRS |
| | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers |
| | hadoop.hbase.replication.TestReplicationKillSlaveRS |
| Timed out junit tests | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
| | org.apache.hadoop.hbase.security.access.TestAccessController |
| | org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12842447/hbase-9774_v1.patch |
| JIRA Issue | HBASE-9774 |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux c90a8cb4b0ff 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh |
| git revision | master / b3ae87b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/whitespace-eol.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/new-findbugs-hbase-examples.html |
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/diff-javadoc-javadoc-hbase-metrics-api.txt |
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/diff-javadoc-javadoc-root.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-unit-root.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-unit-hbase-metrics.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-unit-hbase-server.txt |
| unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-unit-root.txt https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-unit-hbase-metrics.txt https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hbase-common hbase-client hbase-metrics-api hbase-hadoop-compat . hbase-assembly hbase-examples hbase-hadoop2-compat hbase-metrics hbase-server U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4849/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Provide a way for coprocessors to register and report custom metrics
> --------------------------------------------------------------------
>
> Key: HBASE-9774
> URL: https://issues.apache.org/jira/browse/HBASE-9774
> Project: HBase
> Issue Type: New Feature
> Components: Coprocessors, metrics
> Reporter: Gary Helmling
> Assignee: Enis Soztutar
> Attachments: hbase-9774_v1.patch
>
>
> It would help provide better visibility into what coprocessors are doing if we provided a way for coprocessors to export their own metrics. The general idea is to:
> * extend access to the HBase "metrics bus" down into the coprocessor environments
> * coprocessors can then register and increment custom metrics
> * coprocessor metrics are then reported along with all others through normal mechanisms
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)