[GitHub] hddong commented on a change in pull request #23837: [SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline

[GitBox <gi...@apache.org>]

hddong commented on a change in pull request #23837: [SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline
URL: https://github.com/apache/spark/pull/23837#discussion_r260119297
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -186,7 +187,12 @@ private[hive] class HiveClientImpl(
   /** Returns the configuration for the current session. */
   def conf: HiveConf = state.getConf
 
-  private val userName = conf.getUser
 
 Review comment:
   this source code of conf.getUser is:
   `public String getUser() throws IOException {`
   `        try {`
   `             UserGroupInformation ugi = Utils.getUGI();` 
   `             return ugi.getUserName();` 
   `         } catch (LoginException var2) {` 
   `             throw new IOException(var2);` 
   `         }` 
   `     }` 
   this chang just use ugi.getShortUserName instead of ugi.getUserName()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org