You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/04/05 10:05:22 UTC
Review Request 58206: Complete node name is not shown when node name
is larger than 17 characters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58206/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20678
https://issues.apache.org/jira/browse/AMBARI-20678
Repository: ambari
Description
-------
Introduced ellipsis css class and showing complete name as tooltip.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1cfcb15
Diff: https://reviews.apache.org/r/58206/diff/1/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 58206: Complete node name is not shown when node
name is larger than 17 characters
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58206/
-----------------------------------------------------------
(Updated April 21, 2017, 3:43 p.m.)
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20678
https://issues.apache.org/jira/browse/AMBARI-20678
Repository: ambari
Description
-------
Introduced ellipsis css class and showing complete name as tooltip.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/adapters/application.js 42935fc
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 78aa39d
Diff: https://reviews.apache.org/r/58206/diff/2/
Changes: https://reviews.apache.org/r/58206/diff/1-2/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 58206: Complete node name is not shown when node
name is larger than 17 characters
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58206/#review171323
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On April 5, 2017, 10:05 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58206/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 10:05 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20678
> https://issues.apache.org/jira/browse/AMBARI-20678
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Introduced ellipsis css class and showing complete name as tooltip.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1cfcb15
>
>
> Diff: https://reviews.apache.org/r/58206/diff/1/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 58206: Complete node name is not shown when node
name is larger than 17 characters
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58206/#review171138
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On April 5, 2017, 10:05 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58206/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 10:05 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20678
> https://issues.apache.org/jira/browse/AMBARI-20678
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Introduced ellipsis css class and showing complete name as tooltip.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1cfcb15
>
>
> Diff: https://reviews.apache.org/r/58206/diff/1/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>