You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2018/05/23 10:32:41 UTC

[GitHub] flink issue #5846: [FLINK-9143] [client] Restart strategy defined in flink-c...

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/5846
  
    @yuqi1129 Thank you for your contribution. 
    
    Did I understand this change correctly that it only affects situation when the checkpointing is disabled? Currently in this case the `RestartStrategy` will be set from cluster's `flink-conf.yaml`. After your change the cluster configuration will never be taken into account (neither with nor without checkpointing). Therefore I would be against merging it in current shape, as it does not address the original problem, but just changes only one of many corner cases.
    
    What do you think about such strategy for resolving `RestartStrategy`?:
    
    1. job config
      * set in code
      * client configuration
      * (no default, even in case of checkpointing)
    2. cluster config
      * cluster configuration (flink-conf)
      * default value = FixedDelayRestart (might be only in case of checkpointing)


---