Re: [PR] feat: Add projection to HashJoinExec. [arrow-datafusion]

["my-vegetable-has-exploded (via GitHub)" <gi...@apache.org>]

my-vegetable-has-exploded commented on PR #9236:
URL: https://github.com/apache/arrow-datafusion/pull/9236#issuecomment-1974818649

   Sorry for late response. I added some tests and more comments.
   
   >     2. **Projection Length Check**: The check **`projection_index.len() >= hash_join.schema().fields().len()`** is slightly unclear. A comment explaining the logic behind this check would be beneficial. For instance, if the intent is to verify that the projection doesn't have more fields than the hash join, explaining why this condition leads to an early return would be helpful.
   
   This check follows other function in `projection_pushdown`. But it seems that  we don't need it here.
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org