You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/07 21:22:55 UTC

[GitHub] [hudi] slachiewicz opened a new pull request, #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

slachiewicz opened a new pull request, #5784:
URL: https://github.com/apache/hudi/pull/5784

   ## What is the purpose of the pull request
   
   Upgrade Protobuf to latest available version
   
   ## Brief change log
   
     - Upgrade Protobuf to 3.21.1 to support project compilation on macOS M1 (aarm64).
     - [CVE-2021-22569](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22569) High - CVSS Score: 7.5, An implementation weakness in how unknown fields are parsed in Java. A small (~800 KB) malicious payload can occupy the parser for several minutes by creating large numbers of short-lived objects that cause frequent, repeated GC pauses.
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests
   
   ## Committer checklist
   
    - [X] Has a corresponding JIRA in PR title & commit
    
    - [X] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] jonvex commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
jonvex commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1248524295

   Ok. I have tested it and it builds and also the kafka connector test worked


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slachiewicz commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1253472762

   Could you say more? What kind of error you have?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1149222481

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138",
       "triggerID" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 221cb49c0c2c25e8806c7e24b2b321efc277795e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1253563806

   @slachiewicz please check this issue - https://github.com/apache/hudi/issues/6724. 
   
   Any help is most appreciated since I am stuck on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1242772646

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138",
       "triggerID" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0b74754cbecfee0a11ea7d856c0f1545df5160a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d0b74754cbecfee0a11ea7d856c0f1545df5160a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 221cb49c0c2c25e8806c7e24b2b321efc277795e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138) 
   * d0b74754cbecfee0a11ea7d856c0f1545df5160a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1149185780

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 221cb49c0c2c25e8806c7e24b2b321efc277795e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
yihua merged PR #5784:
URL: https://github.com/apache/hudi/pull/5784


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1245017791

   Makes sense to align the versions. The thing i'm not sure is why they are in different versions in the first place? was it due to something not working with newer protoc? if we can clarify and verify this, then we should be good to go. cc @jonvex @nsivabalan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] pratyakshsharma commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1253471675

   this does not seem to work on my M1 machine @xushiyan @slachiewicz


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1242773524

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138",
       "triggerID" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0b74754cbecfee0a11ea7d856c0f1545df5160a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11295",
       "triggerID" : "d0b74754cbecfee0a11ea7d856c0f1545df5160a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 221cb49c0c2c25e8806c7e24b2b321efc277795e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138) 
   * d0b74754cbecfee0a11ea7d856c0f1545df5160a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11295) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1246082135

   @jonvex : can you verify once that the patch works in your env. and we are good to land then. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1149258494

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138",
       "triggerID" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 221cb49c0c2c25e8806c7e24b2b321efc277795e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1242794838

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9138",
       "triggerID" : "221cb49c0c2c25e8806c7e24b2b321efc277795e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0b74754cbecfee0a11ea7d856c0f1545df5160a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11295",
       "triggerID" : "d0b74754cbecfee0a11ea7d856c0f1545df5160a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d0b74754cbecfee0a11ea7d856c0f1545df5160a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11295) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slachiewicz commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.1

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1239530386

   #6535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #5784: [HUDI-4193] Upgrade Protobuf to 3.21.5

Posted by GitBox <gi...@apache.org>.
yihua commented on PR #5784:
URL: https://github.com/apache/hudi/pull/5784#issuecomment-1245012787

   @nsivabalan @xushiyan @jonvex Is this good to land?  Any manual testing required?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org