You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/07/10 12:00:22 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #41921: [SPARK-44352][CONNECT] Put back sameType and friends in DataType.
hvanhovell opened a new pull request, #41921:
URL: https://github.com/apache/spark/pull/41921
### What changes were proposed in this pull request?
This PR moves back sameType and friends into DataType. Now that we have a conf system for SQL/API we can host them in there.
### Why are the changes needed?
We want to retain compatibility with the existing DataType APIs. Also we need to eliminate the use of catalyst specific code in the DataType hierarchy.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #41921: [SPARK-44352][CONNECT] Put back sameType and friends in DataType.
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #41921: [SPARK-44352][CONNECT] Put back sameType and friends in DataType.
URL: https://github.com/apache/spark/pull/41921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #41921: [SPARK-44352][CONNECT] Put back sameType and friends in DataType.
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #41921:
URL: https://github.com/apache/spark/pull/41921#issuecomment-1628822000
cc @amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org