You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/02/03 18:23:01 UTC

DO NOT REPLY [Bug 48668] New: Template text that looks like a deferred expression can be mishandled even if EL is ignored

https://issues.apache.org/bugzilla/show_bug.cgi?id=48668

           Summary: Template text that looks like a deferred expression
                    can be mishandled even if EL is ignored
           Product: Tomcat 6
           Version: 6.0.24
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Jasper
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: support@netxtra.net


In some cases text that happens to look similar to a deferred expression
(#{..}) can get mangled even if the EL is not active. This appears to only
happen if the text in question immediately proceeds a custom tag (either a full
blown custom tag or a simple .tag file tag). The initial # and { characters get
removed.

This happens in Tomcat v6.0.24 but did not happen in v6.0.20 so appears to be
unintentional.

We have been upgrading legacy sites to Tomcat v6 and have hit this problem.

This problem can be recreated in a bog standard install of Tomcat v6.0.24.
Create a simple .tag file that does nothing more than say 'hello'. Place a
reference to this tag into a JSP with the offending text immediately after it. 

A test JSP that looks something like (note that EL is being ignored)...

<%@ page isELIgnored="true" %>
<%@ taglib tagdir="/WEB-INF/tags/custom" prefix="custom" %>
<html>
<title>Test</title>
</head>
<body>
  <custom:example />#{foo.bar}
</body>
</html>

Where the custom example tag (/WEB-INF/tags/custom/example.tag) looks like
this...

Hello

Rather than the page returning the following...

<html>
<title>Test</title>
</head>
<body>
  Hello#{foo.bar}
</body>
</html>

It will return...

<html>
<title>Test</title>
</head>
<body>
  Hellofoo.bar}
</body>
</html>

Notice the missing # and { from the text.

I don't believe the platform Tomcat is running on matters. Have seen this
behaviour on both Mac OS X and Linux.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 48668] Template text that looks like a deferred expression can be mishandled even if EL is ignored

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48668

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Mark Thomas <ma...@apache.org> 2010-03-09 15:10:23 UTC ---
Additional fixes have been applied to trunk and 6.0.x and will be included in
6.0.26 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 48668] Template text that looks like a deferred expression can be mishandled even if EL is ignored

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48668

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> 2010-03-06 20:51:09 UTC ---
Reopening.

Additional tests added in r919847.
Some of them are failing.

This issue is also reproducible in the current 5.5 using
/test/webapp/bug48668a.jsp from trunk. (bug48668b.jsp is not applicable to 5.5)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 48668] Template text that looks like a deferred expression can be mishandled even if EL is ignored

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48668

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-02-23 23:00:13 UTC ---
This has been fixed in 6.0.x and will be included in 6.0.25 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 48668] Template text that looks like a deferred expression can be mishandled even if EL is ignored

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48668

--- Comment #1 from Mark Thomas <ma...@apache.org> 2010-02-07 18:03:40 UTC ---
Thanks for the report. This has been fixed in trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org