[GitHub] [flink] pnowojski commented on a change in pull request #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist
URL: https://github.com/apache/flink/pull/8759#discussion_r294623991
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
 ##########
 @@ -75,7 +75,12 @@ public void configure(ContainerSpecification container) throws IOException {
 		addPathRecursively(flinkBinPath, TARGET_ROOT, container);
 		addPathRecursively(flinkConfPath, TARGET_ROOT, container);
 		addPathRecursively(flinkLibPath, TARGET_ROOT, container);
-		addPathRecursively(flinkPluginsPath, TARGET_ROOT, container);
+		if (flinkPluginsPath.isDirectory()) {
 
 Review comment:
   Hmm, good question. I was just repeating the same pattern as with `ENV_FLINK_LIB_DIR`. So asking the correct question: why is it obligatory to set `ENV_FLINK_LIB_DIR` for mesos but not for yarn? I have no idea. 
   
   If you want, we can create a ticket to unify those two things - which first step would be to find out which way they should be unified. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services