You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/05/23 20:35:43 UTC

[GitHub] [arrow] zeroshade commented on a diff in pull request #35628: GH-35627: [C++][Format][Integration] Add string view to the arrow format

zeroshade commented on code in PR #35628:
URL: https://github.com/apache/arrow/pull/35628#discussion_r1202973038


##########
format/Message.fbs:
##########
@@ -99,6 +99,12 @@ table RecordBatch {
 
   /// Optional compression of the message body
   compression: BodyCompression;
+
+  /// Some types such as Utf8View are represented using a variable number of buffers.
+  /// For each such Field in the pre-ordered flattened logical schema, there will be
+  /// an entry in variadicCounts to indicate the number of extra buffers which belong
+  /// to that Field.
+  variadicCounts: [long];

Review Comment:
   We probably need to bump the MetadataVersion to V6 to go along with this as anything without the `variadicCounts` field would not be able to safely read a Utf8View/BinaryView field and it should be documented that `<=V5` should reject those types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org