You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/06/20 03:04:29 UTC

Review Request 35680: Added Sorter::allocation() overload for getting resources of a particular slave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35680/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-2891
    https://issues.apache.org/jira/browse/MESOS-2891


Repository: mesos


Description
-------

Needed that for the subsequent review to speed up some allocator operations.


Diffs
-----

  src/master/allocator/sorter/drf/sorter.hpp d38925ef4f6b52404e7f11b83e896fa938ae60a3 
  src/master/allocator/sorter/drf/sorter.cpp 12434a073d1af58b77a8a196dfa9251eb0938db8 
  src/master/allocator/sorter/sorter.hpp 9f7d3ccfd0994be8d562fd5efaeeb9403cf9ce94 
  src/tests/sorter_tests.cpp 4013886dd84e4ba79290e1e9ed814ca17a9702ba 

Diff: https://reviews.apache.org/r/35680/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 35680: Added Sorter::allocation() overload for getting resources of a particular slave.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35680/#review88619
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Park


On June 20, 2015, 1:04 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35680/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 1:04 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-2891
>     https://issues.apache.org/jira/browse/MESOS-2891
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed that for the subsequent review to speed up some allocator operations.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.hpp d38925ef4f6b52404e7f11b83e896fa938ae60a3 
>   src/master/allocator/sorter/drf/sorter.cpp 12434a073d1af58b77a8a196dfa9251eb0938db8 
>   src/master/allocator/sorter/sorter.hpp 9f7d3ccfd0994be8d562fd5efaeeb9403cf9ce94 
>   src/tests/sorter_tests.cpp 4013886dd84e4ba79290e1e9ed814ca17a9702ba 
> 
> Diff: https://reviews.apache.org/r/35680/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 35680: Added Sorter::allocation() overload for getting resources of a particular slave.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35680/#review88617
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On June 20, 2015, 1:04 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35680/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 1:04 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-2891
>     https://issues.apache.org/jira/browse/MESOS-2891
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed that for the subsequent review to speed up some allocator operations.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.hpp d38925ef4f6b52404e7f11b83e896fa938ae60a3 
>   src/master/allocator/sorter/drf/sorter.cpp 12434a073d1af58b77a8a196dfa9251eb0938db8 
>   src/master/allocator/sorter/sorter.hpp 9f7d3ccfd0994be8d562fd5efaeeb9403cf9ce94 
>   src/tests/sorter_tests.cpp 4013886dd84e4ba79290e1e9ed814ca17a9702ba 
> 
> Diff: https://reviews.apache.org/r/35680/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>