[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on code in PR #5033:
URL: https://github.com/apache/hadoop/pull/5033#discussion_r1010316878


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -452,6 +449,9 @@ private synchronized void activateVolume(
       throw new IOException(errorMsg);
     }
     volumeMap.mergeAll(replicaMap);
+    for (String bp : volumeMap.getBlockPoolList()) {

Review Comment:
   Could `storageMap` meet some concurrent-modify issues when move hold lock logic here? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org