You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Artem Shutak <as...@gridgain.com> on 2015/12/01 15:39:31 UTC
Disabling patch-validation mechanism on TC
Igniters,
I'm working on adding to TC 4 windows agents. All Ignite build have "Apply
patch (if exist)" step which currently fails on Windows.
I'm going to disable this step, it will disable "Patch validation"
mechanism on TC [1]. As a result no one will be able to run TC for a patch
file attached to jira. I want to remind that we have Pull-Request approach
which can be used instead.
"Patch validation" approach will be enabled back in 2 weeks.
Any objections?
[1]
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file
Thanks,
-- Artem --
Re: Disabling patch-validation mechanism on TC
Posted by Artem Shutak <as...@gridgain.com>.
Thanks, Denis!
Disabled patch-based approach on TC.
-- Artem --
On Tue, Dec 1, 2015 at 9:23 PM, Denis Magda <dm...@gridgain.com> wrote:
> Removed patch-based information from the site. Placed a direct link to
> wiki that describes how to contribute using pull-requests instead.
>
> —
> Denis
>
> > On 1 дек. 2015 г., at 17:56, Denis Magda <dm...@gridgain.com> wrote:
> >
> > Fully support this endeavor.
> >
> > However, we have to update not only the wiki page after that but the
> start contributing section as well [2]
> > I'll try to find time and update [2] today.
> >
> > [2] https://ignite.apache.org/community/contribute.html#contribute
> >
> > --
> > Denis
> >
> > On 12/1/2015 5:39 PM, Artem Shutak wrote:
> >> Igniters,
> >>
> >> I'm working on adding to TC 4 windows agents. All Ignite build have
> "Apply
> >> patch (if exist)" step which currently fails on Windows.
> >>
> >> I'm going to disable this step, it will disable "Patch validation"
> >> mechanism on TC [1]. As a result no one will be able to run TC for a
> patch
> >> file attached to jira. I want to remind that we have Pull-Request
> approach
> >> which can be used instead.
> >>
> >> "Patch validation" approach will be enabled back in 2 weeks.
> >>
> >> Any objections?
> >>
> >> [1]
> >>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file
> >>
> >> Thanks,
> >> -- Artem --
> >>
>
>
Re: Disabling patch-validation mechanism on TC
Posted by Denis Magda <dm...@gridgain.com>.
Removed patch-based information from the site. Placed a direct link to wiki that describes how to contribute using pull-requests instead.
—
Denis
> On 1 дек. 2015 г., at 17:56, Denis Magda <dm...@gridgain.com> wrote:
>
> Fully support this endeavor.
>
> However, we have to update not only the wiki page after that but the start contributing section as well [2]
> I'll try to find time and update [2] today.
>
> [2] https://ignite.apache.org/community/contribute.html#contribute
>
> --
> Denis
>
> On 12/1/2015 5:39 PM, Artem Shutak wrote:
>> Igniters,
>>
>> I'm working on adding to TC 4 windows agents. All Ignite build have "Apply
>> patch (if exist)" step which currently fails on Windows.
>>
>> I'm going to disable this step, it will disable "Patch validation"
>> mechanism on TC [1]. As a result no one will be able to run TC for a patch
>> file attached to jira. I want to remind that we have Pull-Request approach
>> which can be used instead.
>>
>> "Patch validation" approach will be enabled back in 2 weeks.
>>
>> Any objections?
>>
>> [1]
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file
>>
>> Thanks,
>> -- Artem --
>>
Re: Disabling patch-validation mechanism on TC
Posted by Denis Magda <dm...@gridgain.com>.
Fully support this endeavor.
However, we have to update not only the wiki page after that but the
start contributing section as well [2]
I'll try to find time and update [2] today.
[2] https://ignite.apache.org/community/contribute.html#contribute
--
Denis
On 12/1/2015 5:39 PM, Artem Shutak wrote:
> Igniters,
>
> I'm working on adding to TC 4 windows agents. All Ignite build have "Apply
> patch (if exist)" step which currently fails on Windows.
>
> I'm going to disable this step, it will disable "Patch validation"
> mechanism on TC [1]. As a result no one will be able to run TC for a patch
> file attached to jira. I want to remind that we have Pull-Request approach
> which can be used instead.
>
> "Patch validation" approach will be enabled back in 2 weeks.
>
> Any objections?
>
> [1]
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-2.CreateaPatch-file
>
> Thanks,
> -- Artem --
>