[jira] [Commented] (DRILL-4792) Include session options used for a query as part of the profile

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606046#comment-15606046 ] 

ASF GitHub Bot commented on DRILL-4792:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/551#discussion_r84965750
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -107,6 +107,42 @@
       <p>FOREMAN: ${model.getProfile().getForeman().getAddress()}</p>
       <p>TOTAL FRAGMENTS: ${model.getProfile().getTotalFragments()}</p>
     
    +  <#if (model.getOptionList()?size > 0)>
    +    <div class="page-header"></div>
    +    <h3>Session Options</h3>
    +    <div class="panel-group" id="session-options-accordion">
    +      <div class="panel panel-default">
    +        <div class="panel-heading">
    +          <h4 class="panel-title">
    +            <a data-toggle="collapse" href="#session-options-overview">
    +              Overview
    +            </a>
    +          </h4>
    +        </div>
    +        <div id="session-options-overview" class="panel-collapse collapse in">
    +          <div class="panel-body">
    +            <table class="table table-bordered">
    +              <thead>
    +                <tr>
    +                  <th>Name</th>
    +                  <th>Value</th>
    +                </tr>
    +              </thead>
    +              <tbody>
    +                <#list model.getOptionList() as option>
    +                  <tr>
    +                    <td>${option.getName()}</td>
    +                    <td>${option.getValue()?c}</td>
    --- End diff --
    
    What does `?c` do?


> Include session options used for a query as part of the profile
> ---------------------------------------------------------------
>
>                 Key: DRILL-4792
>                 URL: https://issues.apache.org/jira/browse/DRILL-4792
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Arina Ielchiieva
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: no_session_options.JPG, session_options_block.JPG, session_options_collapsed.JPG, session_options_json.JPG
>
>
> Include session options used for a query as part of the profile.
> This will be very useful for debugging/diagnostics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)