[GitHub] kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

[GitBox <gi...@apache.org>]

kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201527129
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
 ##########
 @@ -49,15 +55,25 @@
   public final RelDataType getRowType(RelDataTypeFactory factory) {
     final List<SqlTypeName> types = getFieldSqlTypeNames();
     final List<String> names = getFieldNames();
+    final List<Boolean> nullables = getFieldNullability();
     final List<RelDataType> fields = Lists.newArrayList();
-    for (final SqlTypeName typeName : types) {
+    Iterator<SqlTypeName> typesIter = types.listIterator();
+    Iterator<Boolean> nullabilityIter = nullables.listIterator();
 
 Review comment:
   I wanted to avoid changing existing implementation, so I added an extra list and iterated in parallel.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services