You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tibor Digana <ti...@apache.org> on 2017/12/03 12:21:28 UTC
Surefire at Java 9 and Java 10
As discussed before about Java 9.
I will try to run Surefire integration tests with JDK 9 and 10 on Linux and
I will add JDK 8/9 to CI pipeline.
I do not expect any bugs here. Maybe only enabling some modules for the ITs
in worst case.
Surefire supports Jigsaw already now in origin/master.
There are more important two or three bugs when Docker build crashes and
this has to be fixed till 2.21.0 as well.
Cheers
Tibor
Re: Surefire at Java 9 and Java 10
Posted by Enrico Olivelli <eo...@gmail.com>.
Il dom 3 dic 2017, 17:34 Tibor Digana <ti...@apache.org> ha scritto:
> 6 months is quite far away.
> No reason to be afraid because I can check it nowadays and we will see how
> much of the ITs is broken.
> The problem in Java 9 was that Oracle broke backwards compatibility and
> they did not give us a chance to re-introduce extensions (removed modules)
> back to JDK. I expected from Oracle to release extensible JDK (modules/api
> + languages).
> If they did not break it again in 10 then it should not mean any difference
> between 9 and 10 for our tests.
>
Works for me
I will follow your updates.
Enrico
>
> On Sun, Dec 3, 2017 at 5:23 PM, Tibor Digana <ti...@googlemail.com>
> wrote:
>
> > Look, I do not want to force our contributors to rely on java 9 or java
> > 10. They can use their default jdk.
> > My strategy is to fallback to default jdk unless jdk.home system property
> > is specified.
> > I am fine with Jenkins multi-branch if it fails on java 9 before
> > integrating a branch to master.
> > It happens that the broken branch has to be overridden by build fix and
> > then the success can be integrated to master.
> >
> > On Sun, Dec 3, 2017 at 4:03 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> >> Tibor,
> >> There are IT tests which check for exaclty java.specification.version=9
> >> How are we going to deal with them?
> >> It seems that a new major release will appear every 6 months
> >> IMHO it will be enough to drop that assertion
> >>
> >> Enrico
> >>
> >> Il dom 3 dic 2017, 13:21 Tibor Digana <ti...@apache.org> ha
> >> scritto:
> >>
> >> > As discussed before about Java 9.
> >> > I will try to run Surefire integration tests with JDK 9 and 10 on
> Linux
> >> and
> >> > I will add JDK 8/9 to CI pipeline.
> >> > I do not expect any bugs here. Maybe only enabling some modules for
> the
> >> ITs
> >> > in worst case.
> >> >
> >> > Surefire supports Jigsaw already now in origin/master.
> >> >
> >> > There are more important two or three bugs when Docker build crashes
> and
> >> > this has to be fixed till 2.21.0 as well.
> >> >
> >> > Cheers
> >> > Tibor
> >> >
> >> --
> >>
> >>
> >> -- Enrico Olivelli
> >>
> >
> >
> >
> > --
> > Cheers
> > Tibor
> >
>
--
-- Enrico Olivelli
Re: Surefire at Java 9 and Java 10
Posted by Tibor Digana <ti...@apache.org>.
6 months is quite far away.
No reason to be afraid because I can check it nowadays and we will see how
much of the ITs is broken.
The problem in Java 9 was that Oracle broke backwards compatibility and
they did not give us a chance to re-introduce extensions (removed modules)
back to JDK. I expected from Oracle to release extensible JDK (modules/api
+ languages).
If they did not break it again in 10 then it should not mean any difference
between 9 and 10 for our tests.
On Sun, Dec 3, 2017 at 5:23 PM, Tibor Digana <ti...@googlemail.com>
wrote:
> Look, I do not want to force our contributors to rely on java 9 or java
> 10. They can use their default jdk.
> My strategy is to fallback to default jdk unless jdk.home system property
> is specified.
> I am fine with Jenkins multi-branch if it fails on java 9 before
> integrating a branch to master.
> It happens that the broken branch has to be overridden by build fix and
> then the success can be integrated to master.
>
> On Sun, Dec 3, 2017 at 4:03 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> Tibor,
>> There are IT tests which check for exaclty java.specification.version=9
>> How are we going to deal with them?
>> It seems that a new major release will appear every 6 months
>> IMHO it will be enough to drop that assertion
>>
>> Enrico
>>
>> Il dom 3 dic 2017, 13:21 Tibor Digana <ti...@apache.org> ha
>> scritto:
>>
>> > As discussed before about Java 9.
>> > I will try to run Surefire integration tests with JDK 9 and 10 on Linux
>> and
>> > I will add JDK 8/9 to CI pipeline.
>> > I do not expect any bugs here. Maybe only enabling some modules for the
>> ITs
>> > in worst case.
>> >
>> > Surefire supports Jigsaw already now in origin/master.
>> >
>> > There are more important two or three bugs when Docker build crashes and
>> > this has to be fixed till 2.21.0 as well.
>> >
>> > Cheers
>> > Tibor
>> >
>> --
>>
>>
>> -- Enrico Olivelli
>>
>
>
>
> --
> Cheers
> Tibor
>
Re: Surefire at Java 9 and Java 10
Posted by Tibor Digana <ti...@googlemail.com>.
Look, I do not want to force our contributors to rely on java 9 or java 10.
They can use their default jdk.
My strategy is to fallback to default jdk unless jdk.home system property
is specified.
I am fine with Jenkins multi-branch if it fails on java 9 before
integrating a branch to master.
It happens that the broken branch has to be overridden by build fix and
then the success can be integrated to master.
On Sun, Dec 3, 2017 at 4:03 PM, Enrico Olivelli <eo...@gmail.com> wrote:
> Tibor,
> There are IT tests which check for exaclty java.specification.version=9
> How are we going to deal with them?
> It seems that a new major release will appear every 6 months
> IMHO it will be enough to drop that assertion
>
> Enrico
>
> Il dom 3 dic 2017, 13:21 Tibor Digana <ti...@apache.org> ha scritto:
>
> > As discussed before about Java 9.
> > I will try to run Surefire integration tests with JDK 9 and 10 on Linux
> and
> > I will add JDK 8/9 to CI pipeline.
> > I do not expect any bugs here. Maybe only enabling some modules for the
> ITs
> > in worst case.
> >
> > Surefire supports Jigsaw already now in origin/master.
> >
> > There are more important two or three bugs when Docker build crashes and
> > this has to be fixed till 2.21.0 as well.
> >
> > Cheers
> > Tibor
> >
> --
>
>
> -- Enrico Olivelli
>
--
Cheers
Tibor
Re: Surefire at Java 9 and Java 10
Posted by Enrico Olivelli <eo...@gmail.com>.
Tibor,
There are IT tests which check for exaclty java.specification.version=9
How are we going to deal with them?
It seems that a new major release will appear every 6 months
IMHO it will be enough to drop that assertion
Enrico
Il dom 3 dic 2017, 13:21 Tibor Digana <ti...@apache.org> ha scritto:
> As discussed before about Java 9.
> I will try to run Surefire integration tests with JDK 9 and 10 on Linux and
> I will add JDK 8/9 to CI pipeline.
> I do not expect any bugs here. Maybe only enabling some modules for the ITs
> in worst case.
>
> Surefire supports Jigsaw already now in origin/master.
>
> There are more important two or three bugs when Docker build crashes and
> this has to be fixed till 2.21.0 as well.
>
> Cheers
> Tibor
>
--
-- Enrico Olivelli