[GitHub] nifi pull request #529: NIFI-2028: Fixed Site-to-Site Transit URI

[markap14 <gi...@git.apache.org>]

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/529#discussion_r72096781
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java ---
    @@ -366,6 +371,17 @@ private int receiveFlowFiles(final Transaction transaction, final ProcessContext
             return flowFilesReceived.size();
         }
     
    +    private String createTransitUri(final Transaction transaction, String sourceFlowFileIdentifier) {
    +        // Use actual uri as transitUri if this transport protocol has meaningful uri.
    +        switch (remoteGroup.getTransportProtocol()) {
    --- End diff --
    
    This feels wrong to me. We should be using the URI that the communicant gives to us, regardless of which implementation is being used. If the URI returned by the HTTP implementation is not meaningful, then we should update the code so that we pass in a more meaningful URI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---