[GitHub] [apisix] spacewander commented on a change in pull request #4830: chore(limit-count): don't return plugin inner error info to caller

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #4830:
URL: https://github.com/apache/apisix/pull/4830#discussion_r689983402



##########
File path: apisix/plugins/limit-count.lua
##########
@@ -184,11 +184,11 @@ function _M.access(conf, ctx)
             return conf.rejected_code
         end
 
-        core.log.error("failed to limit req: ", err)
+        core.log.error("failed to limit count: ", err)
         if conf.allow_degradation then
             return
         end
-        return 500, {error_msg = "failed to limit count: " .. err}

Review comment:
       For compatibility, we still need to return a `{error_msg = "..."}`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org