You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/12/20 00:12:03 UTC

Review Request 64726: Renamed operation protos for consistency.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

Renamed operation protos for consistency.


Diffs
-----

  include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
  include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
  include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
  include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
  include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
  include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
  src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
  src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 


Diff: https://reviews.apache.org/r/64726/diff/1/


Testing
-------


Thanks,

Gaston Kleiman

Re: Review Request 64726: Renamed operation protos for consistency.

Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194195
-----------------------------------------------------------




include/mesos/mesos.proto
Line 1911 (original), 1911 (patched)
<https://reviews.apache.org/r/64726/#comment272914>

    Do we want to consider making this a first-class message?



src/messages/messages.proto
Line 743 (original), 743 (patched)
<https://reviews.apache.org/r/64726/#comment272913>

    Is this still `offer_operations`?


- Chun-Hung Hsiao


On Dec. 20, 2017, 12:11 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 12:11 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64726: Renamed operation protos for consistency.

Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194194
-----------------------------------------------------------




include/mesos/v1/resource_provider/resource_provider.proto
Line 36 (original), 36 (patched)
<https://reviews.apache.org/r/64726/#comment272912>

    s/operation/OPERATION/.
    Ditto in the following lines.



include/mesos/v1/resource_provider/resource_provider.proto
Line 117 (original), 117 (patched)
<https://reviews.apache.org/r/64726/#comment272911>

    s/operation/OPERATION/


- Chun-Hung Hsiao


On Dec. 20, 2017, 12:11 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 12:11 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64726: Renamed operation protos for consistency.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194197
-----------------------------------------------------------

FAIL: mesos-java failed to build.

Reviews applied: `['64726']`

Failed command: `cmake.exe --build . --target mesos-java`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64726

Relevant logs:

- [mesos-java-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64726/logs/mesos-java-build-cmake-stdout.log):

```
  d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(2601): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3091): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]

"D:\DCOS\mesos\src\java\mesos-java.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\java\mesos-jar.vcxproj" (default target) (13) ->
"D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (14) ->
(CustomBuild target) -> 
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [D:\DCOS\mesos\src\mesos-protobufs.vcxproj]

    199 Warning(s)
    1 Error(s)

Time Elapsed 00:12:22.01
```

- [mesos-java-build-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64726/logs/mesos-java-build-CMakeOutput.log):

```
  Creating directory "cmTC_ecfed.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_ecfed.dir\Debug\cmTC_ecfed.tlog\".

InitializeBuildStatus:

  Creating "cmTC_ecfed.dir\Debug\cmTC_ecfed.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_ecfed.dir\Debug\" /Fd"cmTC_ecfed.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_ecfed.dir\Debug\" /Fd"cmTC_ecfed.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_ecfed.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_ecfed.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_ecfed.lib" /MACHINE:X64  /machine:x64 cmTC_ecfed.dir\Debug\src.obj

  cmTC_ecfed.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_ecfed.exe

FinalizeBuildStatus:

  Deleting file "cmTC_ecfed.dir\Debug\cmTC_ecfed.tlog\unsuccessfulbuild".

  Touching "cmTC_ecfed.dir\Debug\cmTC_ecfed.tlog\cmTC_ecfed.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_ecfed.vcxproj" (default targets).

Build succeeded.

    0 Warning(s)

    0 Error(s)

Time Elapsed 00:00:01.01

Source file was:
int main() { return 0; }
```

- [mesos-java-build-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64726/logs/mesos-java-build-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_c422b.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_c422b.dir\Debug\cmTC_c422b.tlog\".

InitializeBuildStatus:

  Creating "cmTC_c422b.dir\Debug\cmTC_c422b.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c422b.dir\Debug\" /Fd"cmTC_c422b.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c422b.dir\Debug\" /Fd"cmTC_c422b.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c422b.vcxproj]

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c422b.vcxproj" (default targets) -- FAILED.

Build FAILED.

"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c422b.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c422b.vcxproj]

    0 Warning(s)

    1 Error(s)

Time Elapsed 00:00:00.60

```

- Mesos Reviewbot Windows

On Dec. 19, 2017, 4:57 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64726: Renamed operation protos for consistency.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194261
-----------------------------------------------------------




include/mesos/mesos.proto
Line 2279 (original), 2277 (patched)
<https://reviews.apache.org/r/64726/#comment272985>

    Should we call this `uuid` because the context is Operation?



include/mesos/scheduler/scheduler.proto
Line 252 (original), 252 (patched)
<https://reviews.apache.org/r/64726/#comment272987>

    ACKNOWLEDGE_OPERATION_STATUS?



include/mesos/scheduler/scheduler.proto
Line 406 (original), 406 (patched)
<https://reviews.apache.org/r/64726/#comment272986>

    Should that be `ACKNOWLEDGE_OPERATION_STATUS` to be consistently with RP api?



include/mesos/scheduler/scheduler.proto
Lines 491-492 (original), 492 (patched)
<https://reviews.apache.org/r/64726/#comment272988>

    Ditto



src/messages/messages.proto
Line 411 (original), 411 (patched)
<https://reviews.apache.org/r/64726/#comment272989>

    Either we use OperationUpdateXXX or OperationStatusXXX, but let's be consistent.


- Jie Yu


On Dec. 20, 2017, 2:53 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 2:53 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64726: Renamed operation protos for consistency.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194266
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 20, 2017, 7:21 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 7:21 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64726: Renamed operation protos for consistency.

Posted by Greg Mann <gr...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194268
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Dec. 20, 2017, 7:21 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 7:21 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8 
>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941 
>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b 
>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>