You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/26 08:42:41 UTC
[GitHub] [skywalking-website] LiteSun opened a new pull request #263: docs: add contributor over time image in team page
LiteSun opened a new pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263
## What is this PR for?
Add contributor over time image in team page.
The image counts the number of contributors to all skywalking-related repositories[1] and combines them into one line.
## Screenshot
refer issue: https://github.com/apache/skywalking/pull/6678
[1]skywalking-related repositories: apache/skywalking,apache/skywalking-website,apache/skywalking-kubernetes,apache/skywalking-rocketbot-ui,apache/skywalking-query-protocol,apache/skywalking-nginx-lua,apache/skywalking-ui,apache/skywalking-cli,apache/skywalking-data-collect-protocol,apache/skywalking-python,apache/skywalking-docker,apache/skywalking-nodejs,apache/skywalking-satellite,apache/skywalking-swck,apache/skywalking-client-js,apache/skywalking-banyandb,apache/skywalking-agent-test-tool,apache/skywalking-rust,apache/skywalking-eyes,apache/skywalking-infra-e2e,apache/skywalking-oal-tool,apache/skywalking-goapi,apache/skywalking-kubernetes-event-exporter,apache/skywalking-kong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827285085
> I think the data is still incorrect. We have 466 for all repositories, and over 368 for one repository. But the graph shows less than 350, what is the gap?
Sorry the wrong image got cached in CDN, I tried to refresh the cache but it seems not working for all edge servers. We might need to wait for some time (~1 day I guess) to let it back to the correct one. But anyway the correct one would look like this.
https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/skywalking&merge=true
But from what we get, there are 402 contributors from skywalking related repos, and 343 contributors directly to `apache/skywalking`. We get the data by fetching Github API to process all commits, so the results would be more similar to what shows on the Github Repo page.
As we noticed, one benefit of using Github API rather than directly process git log, is we could avoid the situation when one account using several email addresses to commit so the result would be higher than the real value. I guess that could be the reason causing the gap.
I could provide some raw data for reference.
**Contributor Number of Each Repo**
Name | Num
-- | --
apache/skywalking | 343
apache/skywalking-rocketbot-ui | 58
apache/skywalking-website | 53
apache/skywalking-ui | 19
apache/skywalking-data-collect-protocol | 18
apache/skywalking-nginx-lua | 17
apache/skywalking-python | 15
apache/skywalking-kubernetes | 13
apache/skywalking-query-protocol | 13
apache/skywalking-agent-test-tool | 11
apache/skywalking-cli | 9
apache/skywalking-docker | 9
apache/skywalking-client-js | 8
apache/skywalking-satellite | 8
apache/skywalking-eyes | 5
apache/skywalking-infra-e2e | 5
apache/skywalking-nodejs | 5
apache/skywalking-swck | 5
apache/skywalking-kong | 4
apache/skywalking-banyandb | 3
apache/skywalking-goapi | 3
apache/skywalking-kubernetes-event-exporter | 3
apache/skywalking-oal-tool | 2
apache/skywalking-rust | 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827286699
Also, we counted people of the repositories belonging to SkyAPM as some agent implementations are there. They chose to not join the foundation, but still working closing with us. From SkyWalking's perspective, it is still a part of us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841715977
> Yeah, we didn't put anonymous contributor accounts on the page.
It's weird since running the script (team.js) give me 344 contributors. Maybe I failed to figure out the structure 😿
But anyway I got the list of 370 contributors, and I'll try to fix it this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-842598930
Cool! I think right now the contributors count is the same 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu edited a comment on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829751187
> @Yiyiyimu @wu-sheng Here it is. https://github.com/apache/skywalking-website/blob/master/scripts/team.js
@Jtrust Thanks for sharing it! So the method is the same we try to get anonymous contributors. I'll try to find if there's something I missed.
BTW, is there any place on the website I could get the result of this script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841677126
Sorry I lost track of this issue 😿
Just look into it and it seems there's something wrong with the contributor list on the webstie. For example, there are only 344 contributors listed for skywalking, but it says there are 370 contributors. So it seems I could not try to find the difference with the list I generate. Hi @Jtrust is there some part I missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] LiteSun commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827284159
> I think the data is still incorrect. We have 466 for all repositories, and over 368 for one repository. But the graph shows less than 350, what is the gap?
Sorry for the mistake. The data display is less than 350 because the chart shows the contributors of apache/skyskywalking single repository, the reason for this problem is the CDN cache, we just forced to refresh the CDN, wait a while to take effect.
For the strategy of data calculation, please @Yiyiyimu update it here later. 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829752577
> > @Yiyiyimu @wu-sheng Here it is. https://github.com/apache/skywalking-website/blob/master/scripts/team.js
>
> @Jtrust Thanks for sharing it! So the method is the same we try to get anonymous contributors. I'll try to find if there's something I missed.
>
> BTW, is there any place on the website I could get the result of this script?
The result is stored in /data/team.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829736002
I can see 469 on the website, it seems very close. @Jtrust Could you point out the codes? I think it is in the codebase already and all open sourced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust edited a comment on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust edited a comment on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841681558
> You could check the website, there are only 344 items 🤣
Yeah, we didn't put anonymous contributors on the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-842696239
Does your SAAS work in the latest codes already? Could you sync with master to make us to see the latest website in preview page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] LiteSun commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-843366720
> Also, I can't see to see the interactive when moving the mouse across the line.
The link(https://contributor-graph-api.apiseven.com/contributors-svg?repo=apache/skywalking&merge=true) returns only an SVG image, which may not have the ability to capture events for interaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu edited a comment on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827287050
> Where and how could we control which repositories should be counted? I think right now, the link doesn't provide that. Is there any way or any way in the future to have that?
> We as the SkyWalking community are expecting a more transparent way when we provide numbers, which are most likely being marketed again and again in many conferences.
Currently we filter all repos with the prefix `apache/skywalking`. We planed to add the option so users could manually choose which repo they need or not, but only in the near future
> Also, we counted people of the repositories belonging to SkyAPM as some agent implementations are there. They chose to not join the foundation, but still working closing with us. From SkyWalking's perspective, it is still a part of us.
Yes that's what I also concern about. I think this could also be achieved when the above feature got published
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust edited a comment on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust edited a comment on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829752577
> > @Yiyiyimu @wu-sheng Here it is. https://github.com/apache/skywalking-website/blob/master/scripts/team.js
>
> @Jtrust Thanks for sharing it! So the method is the same we try to get anonymous contributors. I'll try to find if there's something I missed.
>
> BTW, is there any place on the website I could get the result of this script?
You can run `team.js` locally and the result is stored in /data/team.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841678245
> Sorry I lost track of this issue 😿
>
> Just look into it and it seems there's something wrong with the contributor list on the webstie. For example, there are only 344 contributors listed for skywalking, but it says there are 370 contributors. So it seems I could not try to find the difference with the list I generate. Hi @Jtrust is there some part I missed?
https://api.github.com/repos/apache/skywalking/contributors?page=4&per_page=100&anon=true
Maybe you didn't include the anonymous?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-843012718
Also, I can't see to see the interactive when moving the mouse across the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841941562
@Jtrust Got it. There are bugs getting anonymous contributors
Getting all anonymous contributors from Github API
```
0: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
1: {zhangxin@oneapm.com 2017-01-17 08:59:52 +0000 UTC}
2: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
3: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
4: {394102339@qq.com 2019-11-08 00:16:52 +0000 UTC}
5: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
6: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
7: {lxin96@126.com 2018-11-25 14:14:08 +0000 UTC}
8: {liufei@lianlianpay.com 2020-02-17 15:31:28 +0000 UTC}
9: {adriancole@users.noreply.github.com 2018-08-22 11:04:15 +0000 UTC}
10: {ming_flycash@qq.com 2019-04-20 03:31:15 +0000 UTC}
11: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
12: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
13: {lizl9@asiainfo.com 2016-04-20 14:31:08 +0000 UTC}
14: {iluckysi 2017-10-08 07:08:09 +0000 UTC}
15: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
16: {yushuqiang@yolo24.com 2016-07-01 09:00:41 +0000 UTC}
17: {bwh12398@163.com 2018-08-09 09:49:22 +0000 UTC}
18: {zhongjianno1@qq.com 2021-02-26 16:01:42 +0000 UTC}
19: {chenglei@kjtpay.com.cn 2016-09-30 03:41:33 +0000 UTC}
20: {me@yannxia.info 2019-01-12 04:01:11 +0000 UTC}
21: {c feng 2017-07-07 07:14:12 +0000 UTC}
22: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
23: {lixin40@lenovo.com 2018-11-30 04:12:05 +0000 UTC}
24: {tanzhen@asiainfoc.om 2015-11-09 08:00:33 +0000 UTC}
25: {182148432@qq.com 2020-05-09 12:38:13 +0000 UTC}
```
After removing duplicate
```
0: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
1: {394102339@qq.com 2019-11-08 00:16:52 +0000 UTC}
2: {lizl9@asiainfo.com 2016-04-20 14:31:08 +0000 UTC}
3: {iluckysi 2017-10-08 07:08:09 +0000 UTC}
4: {yushuqiang@yolo24.com 2016-07-01 09:00:41 +0000 UTC}
5: {tanzhen@asiainfoc.om 2015-11-09 08:00:33 +0000 UTC}
6: {182148432@qq.com 2020-05-09 12:38:13 +0000 UTC}
7: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
8: {lxin96@126.com 2018-11-25 14:14:08 +0000 UTC}
9: {bwh12398@163.com 2018-08-09 09:49:22 +0000 UTC}
10: {chenglei@kjtpay.com.cn 2016-09-30 03:41:33 +0000 UTC}
11: {me@yannxia.info 2019-01-12 04:01:11 +0000 UTC}
12: {lixin40@lenovo.com 2018-11-30 04:12:05 +0000 UTC}
13: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
14: {c feng 2017-07-07 07:14:12 +0000 UTC}
15: {zhangxin@oneapm.com 2017-01-17 08:59:52 +0000 UTC}
16: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
17: {liufei@lianlianpay.com 2020-02-17 15:31:28 +0000 UTC}
18: {adriancole@users.noreply.github.com 2018-08-22 11:04:15 +0000 UTC}
19: {ming_flycash@qq.com 2019-04-20 03:31:15 +0000 UTC}
20: {zhongjianno1@qq.com 2021-02-26 16:01:42 +0000 UTC}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-842303605
> @Jtrust Got it. There are bugs getting anonymous contributors
>
> Getting all anonymous contributors from Github API
>
> ```
> 0: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
> 1: {zhangxin@oneapm.com 2017-01-17 08:59:52 +0000 UTC}
> 2: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
> 3: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
> 4: {394102339@qq.com 2019-11-08 00:16:52 +0000 UTC}
> 5: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 6: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
> 7: {lxin96@126.com 2018-11-25 14:14:08 +0000 UTC}
> 8: {liufei@lianlianpay.com 2020-02-17 15:31:28 +0000 UTC}
> 9: {adriancole@users.noreply.github.com 2018-08-22 11:04:15 +0000 UTC}
> 10: {ming_flycash@qq.com 2019-04-20 03:31:15 +0000 UTC}
> 11: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 12: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
> 13: {lizl9@asiainfo.com 2016-04-20 14:31:08 +0000 UTC}
> 14: {iluckysi 2017-10-08 07:08:09 +0000 UTC}
> 15: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 16: {yushuqiang@yolo24.com 2016-07-01 09:00:41 +0000 UTC}
> 17: {bwh12398@163.com 2018-08-09 09:49:22 +0000 UTC}
> 18: {zhongjianno1@qq.com 2021-02-26 16:01:42 +0000 UTC}
> 19: {chenglei@kjtpay.com.cn 2016-09-30 03:41:33 +0000 UTC}
> 20: {me@yannxia.info 2019-01-12 04:01:11 +0000 UTC}
> 21: {c feng 2017-07-07 07:14:12 +0000 UTC}
> 22: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
> 23: {lixin40@lenovo.com 2018-11-30 04:12:05 +0000 UTC}
> 24: {tanzhen@asiainfoc.om 2015-11-09 08:00:33 +0000 UTC}
> 25: {182148432@qq.com 2020-05-09 12:38:13 +0000 UTC}
> ```
>
> After removing duplicate
>
> ```
> 0: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
> 1: {394102339@qq.com 2019-11-08 00:16:52 +0000 UTC}
> 2: {lizl9@asiainfo.com 2016-04-20 14:31:08 +0000 UTC}
> 3: {iluckysi 2017-10-08 07:08:09 +0000 UTC}
> 4: {yushuqiang@yolo24.com 2016-07-01 09:00:41 +0000 UTC}
> 5: {tanzhen@asiainfoc.om 2015-11-09 08:00:33 +0000 UTC}
> 6: {182148432@qq.com 2020-05-09 12:38:13 +0000 UTC}
> 7: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 8: {lxin96@126.com 2018-11-25 14:14:08 +0000 UTC}
> 9: {bwh12398@163.com 2018-08-09 09:49:22 +0000 UTC}
> 10: {chenglei@kjtpay.com.cn 2016-09-30 03:41:33 +0000 UTC}
> 11: {me@yannxia.info 2019-01-12 04:01:11 +0000 UTC}
> 12: {lixin40@lenovo.com 2018-11-30 04:12:05 +0000 UTC}
> 13: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
> 14: {c feng 2017-07-07 07:14:12 +0000 UTC}
> 15: {zhangxin@oneapm.com 2017-01-17 08:59:52 +0000 UTC}
> 16: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
> 17: {liufei@lianlianpay.com 2020-02-17 15:31:28 +0000 UTC}
> 18: {adriancole@users.noreply.github.com 2018-08-22 11:04:15 +0000 UTC}
> 19: {ming_flycash@qq.com 2019-04-20 03:31:15 +0000 UTC}
> 20: {zhongjianno1@qq.com 2021-02-26 16:01:42 +0000 UTC}
> ```
Thanks for sharing. I think you could move on on your side, even better, sending another PR to fix this directly in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu edited a comment on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829731855
> I think the data is still incorrect. We have 466 for all repositories, and over 368 for one repository. But the graph shows less than 350, what is the gap?
Hi @wu-sheng I tried to add the "anonymous" (not bind to github account) contributors from Github API, now (04/30 09:15 UTC+8) I got 364 contributors for skywalking, and 468 for all repos. Do you mind sharing your data or algorithm on how to fetch data, so I could try to find what causes that gap. Or is the gap right now good to you?
---
One more thing to mention, the data above is fetched from all repos on [skywalking project page](https://skywalking.apache.org/docs/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng merged pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841715977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827217016
@juzhiyuan Could you help to update what we ask for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust edited a comment on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust edited a comment on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841681558
> You could check the website, there are only 344 items 🤣
Yeah, we didn't put anonymous contributor accounts on the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829751187
> @Yiyiyimu @wu-sheng Here it is. https://github.com/apache/skywalking-website/blob/master/scripts/team.js
Thanks for sharing it! So the method is the same we try to get anonymous contributors. I'll try to find if there's something I missed.
BTW, is there any place on the website I could get the result of this script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827292362
> We hope this could be ready when SkyWalking accepts this. We don't want to confuse people as this is going to be posted on the website and many presentations. This is actually why I am asking which repositories have been included, we need to configure and set the repository list very clear and open to the community PMC making decisions.
Got it. Thanks for the advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827291360
> Yes that's what I also concern about. I think this could also be achieved when the above feature got published
We hope this could be ready when SkyWalking accepts this. We don't want to confuse people as this is going to be posted on the website and many presentations. This is actually why I am asking which repositories have been included, we need to configure and set the repository list very clear and open to the community PMC making decisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827287050
> Where and how could we control which repositories should be counted? I think right now, the link doesn't provide that. Is there any way or any way in the future to have that?
> We as the SkyWalking community are expecting a more transparent way when we provide numbers, which are most likely being marketed again and again in many conferences.
Currently we filter all repos with the prefix `apache/skywalking`. We planed to add the option so users could manually choose which repo they need or not, but only in the near future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] kezhenxu94 commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-826647774
The legend (`apache/skywalking`) may be considered as a single repo `apache/skywalking`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841680444
> https://api.github.com/repos/apache/skywalking/contributors?page=4&per_page=100&anon=true
> Maybe you didn't include the anonymous?
You could check the website, there are only 344 items 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841681558
> You could check the website, there are only 344 items 🤣
Yeah, we didn't put anonymous contributors on the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] LiteSun commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827277580
> The legend (`apache/skywalking`) may be considered as a single repo `apache/skywalking`
How about adding a line under the Contributor Over Time title: “The chart counts the number of contributors to all repositories related to skywalking”. This will make it a little clearer IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-842343514
@Yiyiyimu Thanks for sharing it! I didn't notice duplicate anonymous users in the list. I will fix the team-page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827286235
> > I think the data is still incorrect. We have 466 for all repositories, and over 368 for one repository. But the graph shows less than 350, what is the gap?
>
> Sorry the wrong image got cached in CDN, I tried to refresh the cache but it seems not working for all edge servers. We might need to wait for some time (~1 day I guess) to let it back to the correct one. But anyway the correct one would look like this.
> https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/skywalking&merge=true
> 
>
> But from what we get, there are 402 contributors from skywalking related repos, and 343 contributors directly to `apache/skywalking`. We get the data by fetching Github API to process all commits, so the results would be more similar to what shows on the Github Repo page.
> 
> As we noticed, one benefit of using Github API rather than directly process git log, is we could avoid the situation when one account using several email addresses to commit so the result would be higher than the real value. I guess that could be the reason causing the gap.
>
> I could provide some raw data for reference.
>
> **Contributor Number of Each Repo**
>
> Name Num
> apache/skywalking 343
> apache/skywalking-rocketbot-ui 58
> apache/skywalking-website 53
> apache/skywalking-ui 19
> apache/skywalking-data-collect-protocol 18
> apache/skywalking-nginx-lua 17
> apache/skywalking-python 15
> apache/skywalking-kubernetes 13
> apache/skywalking-query-protocol 13
> apache/skywalking-agent-test-tool 11
> apache/skywalking-cli 9
> apache/skywalking-docker 9
> apache/skywalking-client-js 8
> apache/skywalking-satellite 8
> apache/skywalking-eyes 5
> apache/skywalking-infra-e2e 5
> apache/skywalking-nodejs 5
> apache/skywalking-swck 5
> apache/skywalking-kong 4
> apache/skywalking-banyandb 3
> apache/skywalking-goapi 3
> apache/skywalking-kubernetes-event-exporter 3
> apache/skywalking-oal-tool 2
> apache/skywalking-rust 1
We are aware of the gap(dozens actually) between GitHub API and git log. Our @Jtrust set up the data, and according to our discussion, we want to count all people in. The missing people are from the very beginning of SkyWalking, we used to accept PR but not use `squash and merge`. So once they didn't set their git mailbox as same as GitHub's setting, we lost them in the statistic.
But still, they are existing in the contributor group, and we want to count them in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-842343514
@Yiyiyimu Thanks for sharing it! I didn't notice duplicate anonymous users in the list. I will fix the team-page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829749988
@Yiyiyimu @wu-sheng Here it is. https://github.com/apache/skywalking-website/blob/master/scripts/team.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-842303605
> @Jtrust Got it. There are bugs getting anonymous contributors
>
> Getting all anonymous contributors from Github API
>
> ```
> 0: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
> 1: {zhangxin@oneapm.com 2017-01-17 08:59:52 +0000 UTC}
> 2: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
> 3: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
> 4: {394102339@qq.com 2019-11-08 00:16:52 +0000 UTC}
> 5: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 6: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
> 7: {lxin96@126.com 2018-11-25 14:14:08 +0000 UTC}
> 8: {liufei@lianlianpay.com 2020-02-17 15:31:28 +0000 UTC}
> 9: {adriancole@users.noreply.github.com 2018-08-22 11:04:15 +0000 UTC}
> 10: {ming_flycash@qq.com 2019-04-20 03:31:15 +0000 UTC}
> 11: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 12: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
> 13: {lizl9@asiainfo.com 2016-04-20 14:31:08 +0000 UTC}
> 14: {iluckysi 2017-10-08 07:08:09 +0000 UTC}
> 15: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 16: {yushuqiang@yolo24.com 2016-07-01 09:00:41 +0000 UTC}
> 17: {bwh12398@163.com 2018-08-09 09:49:22 +0000 UTC}
> 18: {zhongjianno1@qq.com 2021-02-26 16:01:42 +0000 UTC}
> 19: {chenglei@kjtpay.com.cn 2016-09-30 03:41:33 +0000 UTC}
> 20: {me@yannxia.info 2019-01-12 04:01:11 +0000 UTC}
> 21: {c feng 2017-07-07 07:14:12 +0000 UTC}
> 22: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
> 23: {lixin40@lenovo.com 2018-11-30 04:12:05 +0000 UTC}
> 24: {tanzhen@asiainfoc.om 2015-11-09 08:00:33 +0000 UTC}
> 25: {182148432@qq.com 2020-05-09 12:38:13 +0000 UTC}
> ```
>
> After removing duplicate
>
> ```
> 0: {ascrutae@gmail.com 2016-01-22 07:54:25 +0000 UTC}
> 1: {394102339@qq.com 2019-11-08 00:16:52 +0000 UTC}
> 2: {lizl9@asiainfo.com 2016-04-20 14:31:08 +0000 UTC}
> 3: {iluckysi 2017-10-08 07:08:09 +0000 UTC}
> 4: {yushuqiang@yolo24.com 2016-07-01 09:00:41 +0000 UTC}
> 5: {tanzhen@asiainfoc.om 2015-11-09 08:00:33 +0000 UTC}
> 6: {182148432@qq.com 2020-05-09 12:38:13 +0000 UTC}
> 7: {liuweiyi@cmss.chinamobile.com 2019-05-06 03:23:09 +0000 UTC}
> 8: {lxin96@126.com 2018-11-25 14:14:08 +0000 UTC}
> 9: {bwh12398@163.com 2018-08-09 09:49:22 +0000 UTC}
> 10: {chenglei@kjtpay.com.cn 2016-09-30 03:41:33 +0000 UTC}
> 11: {me@yannxia.info 2019-01-12 04:01:11 +0000 UTC}
> 12: {lixin40@lenovo.com 2018-11-30 04:12:05 +0000 UTC}
> 13: {55846420@qq.com 2015-11-09 08:50:09 +0000 UTC}
> 14: {c feng 2017-07-07 07:14:12 +0000 UTC}
> 15: {zhangxin@oneapm.com 2017-01-17 08:59:52 +0000 UTC}
> 16: {295198088@qq.com 2018-04-03 14:54:26 +0000 UTC}
> 17: {liufei@lianlianpay.com 2020-02-17 15:31:28 +0000 UTC}
> 18: {adriancole@users.noreply.github.com 2018-08-22 11:04:15 +0000 UTC}
> 19: {ming_flycash@qq.com 2019-04-20 03:31:15 +0000 UTC}
> 20: {zhongjianno1@qq.com 2021-02-26 16:01:42 +0000 UTC}
> ```
Thanks for sharing. I think you could move on on your side, even better, sending another PR to fix this directly in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827285307
> > The legend (`apache/skywalking`) may be considered as a single repo `apache/skywalking`
>
> How about adding a line under the Contributor Over Time title: “The chart counts the number of contributors to all repositories related to skywalking”. This will make it a little clearer IMO.
Where and how could we control which repositories should be counted? I think right now, the link doesn't provide that. Is there any way or any way in the future to have that?
We as the SkyWalking community are expecting a more transparent way when we provide numbers, which are most likely being marketed again and again in many conferences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-841615034
Do you have any updates about this? Considering there are 2 weeks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-827305231
> We are aware of the gap(dozens actually) between GitHub API and git log. Our @Jtrust set up the data, and according to our discussion, we want to count all people in. The missing people are from the very beginning of SkyWalking, we used to accept PR but not use `squash and merge`. So once they didn't set their git mailbox as same as GitHub's setting, we lost them in the statistic.
> But still, they are existing in the contributor group, and we want to count them in.
That is a good point to me. I'll try to add an option on this later. Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829752327
> BTW, is there any place on the website I could get the result of this script?
Are you asking about this? https://skywalking.apache.org/team/ Contributors section.
The page is built every day 6PM UTC+8 automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829731855
> I think the data is still incorrect. We have 466 for all repositories, and over 368 for one repository. But the graph shows less than 350, what is the gap?
Hi @wu-sheng I tried to add the "anonymous" (not bind to github account) contributors from Github API, now (04/30 09:15 UTC+8) I got 364 contributors for skywalking, and 468 for all repos. Do you mind sharing your data or algorithm on how to fetch data, so I could try to find what causes that gap. Or is the gap right now good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Yiyiyimu commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-829760103
@wu-sheng @Jtrust Thanks for the information! I'll try to fix it later according to this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #263: docs: add contributor over time image in team page
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #263:
URL: https://github.com/apache/skywalking-website/pull/263#issuecomment-843011999
I just check this page, https://deploy-preview-263--skywalking-preview.netlify.app/team/. It seems data updated, but the size of the graph is not suitable to the page, width is not adapting to the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org