You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/02 18:26:05 UTC
[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #2905:
[GOBBLIN-1064]Add writer schema to WorkUnitState
ZihanLi58 opened a new pull request #2905: [GOBBLIN-1064]Add writer schema to WorkUnitState
URL: https://github.com/apache/incubator-gobblin/pull/2905
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1064] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1064
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Add the writer schema for to WorkUnitState
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Make sure at the publish level, workUnitState contains the writer schema
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2905:
[GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2905: [GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable
URL: https://github.com/apache/incubator-gobblin/pull/2905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] ZihanLi58 commented on issue #2905:
[GOBBLIN-1064]Add writer schema to WorkUnitState
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on issue #2905: [GOBBLIN-1064]Add writer schema to WorkUnitState
URL: https://github.com/apache/incubator-gobblin/pull/2905#issuecomment-593639171
@autumnust Can you take a look at this minor change? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2905:
[GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2905: [GOBBLIN-1064]Make KafkaAvroSchemaRegistry extendable
URL: https://github.com/apache/incubator-gobblin/pull/2905#issuecomment-593727502
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=h1) Report
> Merging [#2905](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/998c968cb84ff7a0f3951ae648cb9d2ed1c8e4ad?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2905 +/- ##
============================================
- Coverage 45.86% 45.85% -0.02%
- Complexity 9169 9181 +12
============================================
Files 1932 1933 +1
Lines 72795 72836 +41
Branches 8022 8030 +8
============================================
+ Hits 33389 33400 +11
- Misses 36349 36374 +25
- Partials 3057 3062 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75% <ø> (ø)` | `68 <0> (ø)` | :arrow_down: |
| [...gobblin/metrics/kafka/KafkaAvroSchemaRegistry.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FBdnJvU2NoZW1hUmVnaXN0cnkuamF2YQ==) | `14.81% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [.../hive/filter/LookbackPartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvTG9va2JhY2tQYXJ0aXRpb25GaWx0ZXJHZW5lcmF0b3IuamF2YQ==) | `78.94% <0%> (-21.06%)` | `6% <0%> (+3%)` | |
| [...re/ControllerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0NvbnRyb2xsZXJVc2VyRGVmaW5lZE1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh) | `39.06% <0%> (-12.5%)` | `4% <0%> (ø)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
| [...estli/GobblinServiceFlowConfigResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93Q29uZmlnUmVzb3VyY2VIYW5kbGVyLmphdmE=) | `44.61% <0%> (-6.16%)` | `10% <0%> (-1%)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `53.71% <0%> (-4.58%)` | `19% <0%> (-2%)` | |
| [.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...rg/apache/gobblin/service/FlowConfigsResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1Jlc291cmNlLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...hive/filter/DateRangePartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvRGF0ZVJhbmdlUGFydGl0aW9uRmlsdGVyR2VuZXJhdG9yLmphdmE=) | `50% <0%> (ø)` | `4% <0%> (?)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2905/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=footer). Last update [998c968...c2171dc](https://codecov.io/gh/apache/incubator-gobblin/pull/2905?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services