You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Jarek Jarcec Cecho (Created) (JIRA)" <ji...@apache.org> on 2011/11/12 22:19:51 UTC

[jira] [Created] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Build using maven is broklend due to missing class generated by script write-version-info.sh
--------------------------------------------------------------------------------------------

                 Key: SQOOP-392
                 URL: https://issues.apache.org/jira/browse/SQOOP-392
             Project: Sqoop
          Issue Type: Bug
          Components: build
    Affects Versions: 1.4.0-incubating
            Reporter: Jarek Jarcec Cecho


Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:

[ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
symbol  : class SqoopVersion
location: package org.apache.sqoop

This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155964#comment-13155964 ] 

jiraposter@reviews.apache.org commented on SQOOP-392:
-----------------------------------------------------



bq.  On 2011-11-23 07:07:13, Jarek Cecho wrote:
bq.  > Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit.
bq.  > 
bq.  > Jarcec

Thanks for the review Jarcec. The patch is attached to the JIRA.


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/#review3470
-----------------------------------------------------------


On 2011-11-23 03:29:36, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2920/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-23 03:29:36)
bq.  
bq.  
bq.  Review request for Sqoop and Jarek Cecho.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.
bq.  
bq.  This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.
bq.  
bq.  
bq.  This addresses bug SQOOP-392.
bq.      https://issues.apache.org/jira/browse/SQOOP-392
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /pom.xml 1205214 
bq.    /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 
bq.  
bq.  Diff: https://reviews.apache.org/r/2920/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.
bq.  
bq.  Also tested the build via ant - and all tests passed successfully.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated SQOOP-392:
-----------------------------------

    Fix Version/s: 1.4.1-incubating
           Status: Patch Available  (was: Open)
    
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated SQOOP-392:
-----------------------------------

    Attachment: SQOOP-392-1.patch
    
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Jarcec Cecho updated SQOOP-392:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Patch has been committed. Thank you very much Arvind!
                
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157732#comment-13157732 ] 

Hudson commented on SQOOP-392:
------------------------------

Integrated in Sqoop-jdk-1.6 #65 (See [https://builds.apache.org/job/Sqoop-jdk-1.6/65/])
    SQOOP-392. Build using maven is broken due to missing class generated by script write-version-info.sh

(Arvind Prabhakar via Jarek Jarcec Cecho)

jarcec : http://svn.apache.org/viewvc/?view=rev&rev=1206698
Files : 
* /incubator/sqoop/trunk/pom.xml
* /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java

                
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155662#comment-13155662 ] 

jiraposter@reviews.apache.org commented on SQOOP-392:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Summary
-------

The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.

This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.


This addresses bug SQOOP-392.
    https://issues.apache.org/jira/browse/SQOOP-392


Diffs
-----

  /pom.xml 1205214 
  /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 

Diff: https://reviews.apache.org/r/2920/diff


Testing
-------

The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.

Also tested the build via ant - and all tests passed successfully.


Thanks,

Arvind


                
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "Arvind Prabhakar (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar reassigned SQOOP-392:
--------------------------------------

    Assignee: Arvind Prabhakar
    
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SQOOP-392) Build using maven is broklend due to missing class generated by script write-version-info.sh

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SQOOP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155731#comment-13155731 ] 

jiraposter@reviews.apache.org commented on SQOOP-392:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2920/#review3470
-----------------------------------------------------------

Ship it!


Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit.

Jarcec

- Jarek


On 2011-11-23 03:29:36, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2920/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-23 03:29:36)
bq.  
bq.  
bq.  Review request for Sqoop and Jarek Cecho.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.
bq.  
bq.  This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.
bq.  
bq.  
bq.  This addresses bug SQOOP-392.
bq.      https://issues.apache.org/jira/browse/SQOOP-392
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /pom.xml 1205214 
bq.    /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 
bq.  
bq.  Diff: https://reviews.apache.org/r/2920/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.
bq.  
bq.  Also tested the build via ant - and all tests passed successfully.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Build using maven is broklend due to missing class generated by script write-version-info.sh
> --------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-392
>                 URL: https://issues.apache.org/jira/browse/SQOOP-392
>             Project: Sqoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-392-1.patch
>
>
> Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:
> [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
> symbol  : class SqoopVersion
> location: package org.apache.sqoop
> This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira