You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2015/04/02 05:08:20 UTC

[GitHub] spark pull request: [SPARK-4233] [SQL] WIP:Simplify the UDAF API (...

Github user maropu commented on the pull request:

    https://github.com/apache/spark/pull/3247#issuecomment-88711084
  
    @chenghao-intel I'm also with your refactoring idea though, it's too big to merge into the master in bulk.
    ISTM this patch is better to split into some small ones.
    e.g.)
    - a patch to remove DISTINCT aggregator expression
    - a patch to simplify buffering codes in Aggregate
    - a patch to improve hive integration (Mode, or something)
    - ...
    
    Thought?
    Anyway, I'm interested in your UDTF and UDAF refactoring activities, and so
    I'd like to join that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org