[jira] [Commented] (SLIDER-971) NPE when "slider resolve" with "--out"

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLIDER-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998817#comment-14998817 ] 

Steve Loughran commented on SLIDER-971:
---------------------------------------

you're right: There should be some sanity check here. Looking at the code it should really be going {{File.getCanonicalFile().getParent()}} as {{getParentFile()}} doesn't seem to.

Do you fancy filing a patch here? With a test?

> NPE when "slider resolve" with "--out"
> --------------------------------------
>
>                 Key: SLIDER-971
>                 URL: https://issues.apache.org/jira/browse/SLIDER-971
>             Project: Slider
>          Issue Type: Bug
>          Components: client
>    Affects Versions: Slider 0.80
>            Reporter: kyungwan nam
>            Priority: Minor
>
> this is what i did
> {code}
> slider-0.80.0-incubating/bin/slider resolve --path /users/yarn/services/org-apache-slider/hbase1 --out hbase1_resolved.json
> {code}
> but, that was failed with NPE as follows.
> {code}
> Exception: java.lang.NullPointerException
> 2015-11-10 15:41:44,063 [main] ERROR main.ServiceLauncher - Exception: java.lang.NullPointerException
> java.lang.NullPointerException
>         at org.apache.slider.common.tools.SliderUtils.write(SliderUtils.java:2051)
>         at org.apache.slider.client.SliderClient.actionResolve(SliderClient.java:3494)
>         at org.apache.slider.client.SliderClient.exec(SliderClient.java:526)
>         at org.apache.slider.client.SliderClient.runService(SliderClient.java:424)
>         at org.apache.slider.core.main.ServiceLauncher.launchService(ServiceLauncher.java:188)
>         at org.apache.slider.core.main.ServiceLauncher.launchServiceRobustly(ServiceLauncher.java:475)
>         at org.apache.slider.core.main.ServiceLauncher.launchServiceAndExit(ServiceLauncher.java:403)
>         at org.apache.slider.core.main.ServiceLauncher.serviceMain(ServiceLauncher.java:630)
>         at org.apache.slider.Slider.main(Slider.java:49)
> 2015-11-10 15:41:44,065 [main] INFO  util.ExitUtil - Exiting with status 56
> {code}
> I think that "parentDir" in "SliderUtils.write" should be checked whether that is null or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)