You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@excalibur.apache.org by Stefano Bagnara <ap...@bago.org> on 2007/07/08 20:29:18 UTC

Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

I just tried to update our application (Apache JAMES Server)
dependencies and I noticed that after upgrading cornerstone jars the
server does not work anymore.

Looking into the jars I found out that there are no more xinfo
descriptors inside those libraries.

Is this intended or is it a bug?

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by J Aaron Farr <fa...@apache.org>.
Stefano Bagnara <ap...@bago.org> writes:

> I guess very few people is using this xinfo and in our last JAMES Server
> release we shipped patched cornerstone datasource and cornerstone
> sockets impl because of bad schema validation in official 2.1 jars.

I can't speak for everyone, but I know I haven't used the xinfo
features.  That would be why I haven't caught this before.


-- 
  J Aaron Farr     jadetower.com        [US] +1 724-964-4515 
    馮傑仁          cubiclemuses.com     [HK] +852 8123-7905  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Stefano Bagnara <ap...@bago.org>.
Jorg Heymans ha scritto:
> Stefano Bagnara wrote:
> 
>> Well, removing the schema declaration simply avoid checks. So the
>> backward incompatibility is there only if you add schema declarations,
>> not if you remove them. Of course you are removing details, but I think
>> not too much people is using them anymore as EXLBR-30 is there since
>> almost 2 years and no one else complained but me, and current 2.2.1
>> (online since february) artifacts do not work in xinfo based frameworks,
>> and again no one complained but me ;-)
> 
> Makes sense :) I'll do the changes over the weekend and make a new
> snapshot available.
> 
> Regards,
> Jorg

Thank you!
Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Jorg Heymans <jh...@apache.org>.
Stefano Bagnara wrote:

> Well, removing the schema declaration simply avoid checks. So the
> backward incompatibility is there only if you add schema declarations,
> not if you remove them. Of course you are removing details, but I think
> not too much people is using them anymore as EXLBR-30 is there since
> almost 2 years and no one else complained but me, and current 2.2.1
> (online since february) artifacts do not work in xinfo based frameworks,
> and again no one complained but me ;-)

Makes sense :) I'll do the changes over the weekend and make a new 
snapshot available.

Regards,
Jorg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Stefano Bagnara <ap...@bago.org>.
Jorg Heymans ha scritto:
> Stefano Bagnara wrote:
>> [...]
>> As I have had this problem in past [1] for some of them, I suggest to
>> simply remove the schema declaration from the xinfo.
>> So any:
>>   <block>
>>     <version>1.0</version>
>>     <schema-type>#something#</schema-type>
>>   </block>
>> Will be
>>   <block>
>>     <version>1.0</version>
>>   </block>
>>
>> This happens, to me, at least for this files:
>> DefaultDataSourceSelector.xinfo
>> DefaultSocketManager.xinfo
>> DefaultThreadManager.xinfo
>> ResourceLimitingThreadManager.xinfo
>> [...]
> 
> Is this change potentially backwards incompatible ? I'm not using the
> cornerstone libs so i can't really judge its impact.

Well, removing the schema declaration simply avoid checks. So the
backward incompatibility is there only if you add schema declarations,
not if you remove them. Of course you are removing details, but I think
not too much people is using them anymore as EXLBR-30 is there since
almost 2 years and no one else complained but me, and current 2.2.1
(online since february) artifacts do not work in xinfo based frameworks,
and again no one complained but me ;-)

I guess very few people is using this xinfo and in our last JAMES Server
release we shipped patched cornerstone datasource and cornerstone
sockets impl because of bad schema validation in official 2.1 jars.

> If the other developers agree i will apply your patch and we can do
> another release.

Thank you!!

Stefano

> Thanks,
> Jorg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Jorg Heymans <jh...@apache.org>.
Stefano Bagnara wrote:

> I just tried the 2.2.2-SNAPSHOTs and the xinfos are there, but I have a
> problem with validation.
> 
> The xinfo currently report:
> <schema-type>relax-ng</schema-type>
> or:
> <schema-type>http://relaxng.org/ns/structure/1.0</schema-type>
> 
> But there are no schema for the configurations.
> 
> As I have had this problem in past [1] for some of them, I suggest to
> simply remove the schema declaration from the xinfo.
> So any:
>   <block>
>     <version>1.0</version>
>     <schema-type>#something#</schema-type>
>   </block>
> Will be
>   <block>
>     <version>1.0</version>
>   </block>
> 
> This happens, to me, at least for this files:
> DefaultDataSourceSelector.xinfo
> DefaultSocketManager.xinfo
> DefaultThreadManager.xinfo
> ResourceLimitingThreadManager.xinfo
> 
> Stefano
> 
> [1] EXLBR-30 Wrong schema definition for cornerstone datasources block
>     https://issues.apache.org/jira/browse/EXLBR-30
> 

Is this change potentially backwards incompatible ? I'm not using the 
cornerstone libs so i can't really judge its impact.

If the other developers agree i will apply your patch and we can do 
another release.

Thanks,
Jorg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Stefano Bagnara <ap...@bago.org>.
Jorg Heymans ha scritto:
> Stefano Bagnara wrote:
> 
>> The xinfo is in the same package/folder of the described class. Its name
>> is classname.xinfo.
>>
>> e.g:
>> cornerstone-sockets-impl-2.1.jar
>> org\apache\avalon\cornerstone\blocks\sockets\DefaultSocketManager.xinfo
>>
>> in
>> cornerstone-sockets-impl-2.2.1.jar
>> there is no more this file.
>>
> 
> Would you mind dropping these jars [1] in your app and check if it
> works? The xinfo files are present now.
> 
> Jorg
> 
> [1] http://people.apache.org/~jheymans/releases/cornerstone/

Hi Jorg,
thank you for your fast reply!

I just tried the 2.2.2-SNAPSHOTs and the xinfos are there, but I have a
problem with validation.

The xinfo currently report:
<schema-type>relax-ng</schema-type>
or:
<schema-type>http://relaxng.org/ns/structure/1.0</schema-type>

But there are no schema for the configurations.

As I have had this problem in past [1] for some of them, I suggest to
simply remove the schema declaration from the xinfo.
So any:
  <block>
    <version>1.0</version>
    <schema-type>#something#</schema-type>
  </block>
Will be
  <block>
    <version>1.0</version>
  </block>

This happens, to me, at least for this files:
DefaultDataSourceSelector.xinfo
DefaultSocketManager.xinfo
DefaultThreadManager.xinfo
ResourceLimitingThreadManager.xinfo

Stefano

[1] EXLBR-30 Wrong schema definition for cornerstone datasources block
    https://issues.apache.org/jira/browse/EXLBR-30


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Jorg Heymans <jh...@apache.org>.
Stefano Bagnara wrote:

> The xinfo is in the same package/folder of the described class. Its name
> is classname.xinfo.
> 
> e.g:
> cornerstone-sockets-impl-2.1.jar
> org\apache\avalon\cornerstone\blocks\sockets\DefaultSocketManager.xinfo
> 
> in
> cornerstone-sockets-impl-2.2.1.jar
> there is no more this file.
> 

Would you mind dropping these jars [1] in your app and check if it 
works? The xinfo files are present now.

Jorg

[1] http://people.apache.org/~jheymans/releases/cornerstone/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Stefano Bagnara <ap...@bago.org>.
Jorg Heymans ha scritto:
> Stefano Bagnara wrote:
>> I just tried to update our application (Apache JAMES Server)
>> dependencies and I noticed that after upgrading cornerstone jars the
>> server does not work anymore.
>>
>> Looking into the jars I found out that there are no more xinfo
>> descriptors inside those libraries.
>>
>> Is this intended or is it a bug?
> 
> That's most likely an artifact of the build conversion m1->m2.
> 
> How are these xinfo files packaged into the jar normally ? I'm not using
> the cornerstone libs so i couldn't verify their working beyond
> compilation and testing.
> 
> Regards
> Jorg

The xinfo is in the same package/folder of the described class. Its name
is classname.xinfo.

e.g:
cornerstone-sockets-impl-2.1.jar
org\apache\avalon\cornerstone\blocks\sockets\DefaultSocketManager.xinfo

in
cornerstone-sockets-impl-2.2.1.jar
there is no more this file.

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Re: Cornerstone 2.2.1 jars from maven repository and xinfo descriptors

Posted by Jorg Heymans <jh...@apache.org>.
Stefano Bagnara wrote:
> I just tried to update our application (Apache JAMES Server)
> dependencies and I noticed that after upgrading cornerstone jars the
> server does not work anymore.
> 
> Looking into the jars I found out that there are no more xinfo
> descriptors inside those libraries.
> 
> Is this intended or is it a bug?

That's most likely an artifact of the build conversion m1->m2.

How are these xinfo files packaged into the jar normally ? I'm not using 
the cornerstone libs so i couldn't verify their working beyond 
compilation and testing.

Regards
Jorg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org