You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by jokerosky <gi...@git.apache.org> on 2016/09/03 17:01:06 UTC
[GitHub] log4net pull request #33: tests fixed + nunit test runner for VS added
GitHub user jokerosky opened a pull request:
https://github.com/apache/log4net/pull/33
tests fixed + nunit test runner for VS added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jokerosky/log4net trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 8b705789f75929b0aae80b2fc2c6d459a557ca2f
Author: Anton Yakovets <jo...@gmail.com>
Date: 2016-09-03T16:57:00Z
test fixed + nunit test runner for VS added
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #33: tests fixed + nunit test runner for VS added
Posted by jokerosky <gi...@git.apache.org>.
Github user jokerosky commented on the issue:
https://github.com/apache/log4net/pull/33
so if tests are fixed and new NuGet package with asp.net core support could appear soon, i close this PR as obsolete :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #33: tests fixed + nunit test runner for VS added
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/log4net/pull/33
The test has been fixed with a different patch (svn revision https://svn.apache.org/repos/asf/logging/log4net/trunk@1759541 which became commit 32b7a3e here).
We can certainly add the NUnitTestAdapter dependency but I'd prefer to keep the license header :-)
Also, given this is supposed to be the VS 2012 solution we might better stick with net4 as target.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net pull request #33: tests fixed + nunit test runner for VS added
Posted by jokerosky <gi...@git.apache.org>.
Github user jokerosky closed the pull request at:
https://github.com/apache/log4net/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---